Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Dunno how this wasn't caught, since I couldn't even get the module to work without fixing this bug. Anyways, ahah_helper.module:145, #file should be file. I attached a patch here for that.
P.S. Great module! :)
Comment | File | Size | Author |
---|---|---|---|
file_fix.patch | 841 bytes | cha0s |
Comments
Comment #1
frenkx CreditAttribution: frenkx commentedA patch for this typo is already submited at #380312: Only AHAH javasript settings are send back and several other issues. You might want to check, if the patch, which fixes also another problem, works for you. If so, consider giving a feedback.
Comment #2
cha0s CreditAttribution: cha0s commentedIsn't it better to limit the scope of patches?
I don't know about the other patch, but it'd be nice to get this fix in. Thanks.
Comment #3
frenkx CreditAttribution: frenkx commentedYes, I agree in general. But since there were at least 3 patches fixing the "#file"-problem I wanted to focus the (patch) review on one issue because I thought that would speed up the process of the module maintainance...
Comment #4
ajayg CreditAttribution: ajayg commentedLooks like issue #380312: Only AHAH javasript settings are send back is not moving forward and atleast for some part of the patch there is reservation expressed by maintainer (see comment#5).
So can we please, atleast move this patch forward as standalone and not getting caught with other issue's speed?
can someone please confirm this is working for them?
Comment #5
wojtha CreditAttribution: wojtha commentedSame issue and same patch is here... #368328: caching of built forms prevents form_state['values'] to be populated from $_POST, but title of this issue fits better.
I can confirm that this patch is working on the clean install of the Drupal 6.13.
Comment #6
ajayg CreditAttribution: ajayg commentedComment #7
Wim LeersDone. Finally.
Commit: http://drupal.org/cvs?commit=264520.