Dunno how this wasn't caught, since I couldn't even get the module to work without fixing this bug. Anyways, ahah_helper.module:145, #file should be file. I attached a patch here for that.

P.S. Great module! :)

CommentFileSizeAuthor
file_fix.patch841 bytescha0s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frenkx’s picture

Status: Needs review » Closed (duplicate)

A patch for this typo is already submited at #380312: Only AHAH javasript settings are send back and several other issues. You might want to check, if the patch, which fixes also another problem, works for you. If so, consider giving a feedback.

cha0s’s picture

Isn't it better to limit the scope of patches?

I don't know about the other patch, but it'd be nice to get this fix in. Thanks.

frenkx’s picture

Yes, I agree in general. But since there were at least 3 patches fixing the "#file"-problem I wanted to focus the (patch) review on one issue because I thought that would speed up the process of the module maintainance...

ajayg’s picture

Status: Closed (duplicate) » Needs review

Looks like issue #380312: Only AHAH javasript settings are send back is not moving forward and atleast for some part of the patch there is reservation expressed by maintainer (see comment#5).

So can we please, atleast move this patch forward as standalone and not getting caught with other issue's speed?

can someone please confirm this is working for them?

wojtha’s picture

Same issue and same patch is here... #368328: caching of built forms prevents form_state['values'] to be populated from $_POST, but title of this issue fits better.

I can confirm that this patch is working on the clean install of the Drupal 6.13.

ajayg’s picture

Status: Needs review » Reviewed & tested by the community
Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

Done. Finally.

Commit: http://drupal.org/cvs?commit=264520.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.