drupal_execute() is evil. this patch gets rid of it for generating issue comments, and instead leverages the followup api we have in project issue. since an auto-followup user has to be configured for it to work, the patch also adds in checks for that and warning messages where appropriate.

CommentFileSizeAuthor
pi_generate.patch4.66 KBhunmonk

Comments

dww’s picture

dww
we/he/they
commented
Status: Fixed » Needs work

A) Why is this true?

you must <a href="!project_issue_settings">configure an Auto-followup user</a> to generate issue comments

I thought the auto-generation of issues and comments grabs random users. We don't want all generated comments to use just the auto-followup user, I don't think.

B) Don't you mean '#type' => 'markup'?

+    $form['no_comments_message'] = array(
+      '#type' => 'item',
...
hunmonk’s picture

hunmonk commented
Status: Needs work » Fixed

A)
check the code -- what you need is a configured user for the followup stuff to work at all. once you have one, you do _not_ need to have that user be the user that creates the comment

B)
no, i mean type item ;) look at it, it looks just fine as is...

dww’s picture

dww
we/he/they
commented

Re: (A): moved to #409498: Fix API for adding issue comments to not require the auto user and not rely on switching global $user

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.