Blog module permissions' descriptions should reflect irrelevance to anonymous users [#404240]

Blog module does not allow anonymous users to post content regardless of the permissions set, and thus the "edit own" and "delete own" permissions also make no sense for the blog module (see blog_access()). The attached patch edits the descriptions provided by the blog module in blog_perm() to include a disclaimer that the irrelevant settings do not apply to anonymous users.

Comment	File	Size	Author
#2	blog_permission_descriptions_02.patch	1.56 KB	cwgordon7
	blog_permission_descriptions_01.patch	1.56 KB	cwgordon7

Comments

Comment #1

17 March 2009 at 01:40

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

cwgordon7 commented 17 March 2009 at 02:25

Status:

Needs work

» Needs review

Status	File	Size
new	blog_permission_descriptions_02.patch	1.56 KB

Sorry about that, $type will, of course, be undefined, we should use a hardcoded 'blog' instead.

Comment #3

damien tournoud commented 18 March 2009 at 23:19

Status:

Needs review

» Reviewed & tested by the community

This is great, those permission descriptions *are* useful, even if that page has a little too much text now.

Comment #4

sun

German

Karlsruhe

commented 24 March 2009 at 03:15

Status:

Reviewed & tested by the community

» Needs work

+  // to clarify that anonymous users can never have blogs, and to assign them
+  // certain permissions doesn't even make sense.

Please do not abbreviations in comments. The "even" might go, too. Maybe the entire comment should be reworked to rather explain the WHYs. "Does not make sense" does not explain anything.

Comment #5

Jaza commented 24 March 2009 at 05:57

I think that this issue can best be solved as part of the larger effort of #248598: Label permissions which are warned about in the user interface. Tempted to mark this duplicate or to close it, but I'll leave that for someone else to decide.

This issue is also a bit different, because it's about some permissions that are simply useless / irrelevant for anonymous users, rather than dangerous. This could perhaps be considered more a bug with blog.module than with the permissions system (for overriding its own permissions such that they're irrelevant for a particular role).