Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
function uc_order_order_state() is defined in uc_order.module but never used anywhere, either in 5.x-1.7 or in 6.x-2.0-beta5. Is this obsolete code?
Comment | File | Size | Author |
---|---|---|---|
#7 | 402768_hook_order_state.patch | 1.43 KB | Island Usurper |
Comments
Comment #1
TR CreditAttribution: TR commentedNever mind. Answered my own question - it's an implementation of hook_order_state().
Comment #2
drewish CreditAttribution: drewish commentedI had a similar question and this answered it for me but i think it's a symptom of the fact that hook_order_status() isn't documented. I'd roll a patch but it's not clear where that should go the API docs for hook_order() suggest that it's in uc_order.module but I'm not seeing it.
Comment #3
andreiashu CreditAttribution: andreiashu commentedDamn... Good thing that you reopened this issue drewish.
uc_protx_vsp_direct payment module doesn't use that hook either... It would indeed be a good thing to document this hook so that module developers can see it.
I'll open an issue in uc_protx_vsp_direct's queue.
Thanks
Comment #4
drewish CreditAttribution: drewish commentedhttp://www.ubercart.org/docs/developer/920/order_states_and_statuses had some useful comments on the difference between states and statuses.
Comment #5
drewish CreditAttribution: drewish commentedjust realized i'd cross posted and screwed up the status.
Comment #6
Island Usurper CreditAttribution: Island Usurper commentedComment #7
Island Usurper CreditAttribution: Island Usurper commentedThere's an API page on ubercart.org now, and I've just committed the patch to docs.php. I suppose that should be named api.php already, but that's not too important yet.