function uc_order_order_state() is defined in uc_order.module but never used anywhere, either in 5.x-1.7 or in 6.x-2.0-beta5. Is this obsolete code?

CommentFileSizeAuthor
#7 402768_hook_order_state.patch1.43 KBIsland Usurper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR’s picture

Status: Active » Closed (fixed)

Never mind. Answered my own question - it's an implementation of hook_order_state().

drewish’s picture

Title: uc_order_order_state() not needed? » hook_order_state() is not documented
Version: 6.x-2.0-beta5 » 6.x-2.x-dev
Component: Code » Documentation
Category: task » bug
Status: Closed (fixed) » Active

I had a similar question and this answered it for me but i think it's a symptom of the fact that hook_order_status() isn't documented. I'd roll a patch but it's not clear where that should go the API docs for hook_order() suggest that it's in uc_order.module but I'm not seeing it.

andreiashu’s picture

Priority: Minor » Normal

Damn... Good thing that you reopened this issue drewish.
uc_protx_vsp_direct payment module doesn't use that hook either... It would indeed be a good thing to document this hook so that module developers can see it.

I'll open an issue in uc_protx_vsp_direct's queue.

Thanks

drewish’s picture

Priority: Normal » Minor

http://www.ubercart.org/docs/developer/920/order_states_and_statuses had some useful comments on the difference between states and statuses.

drewish’s picture

Priority: Minor » Normal

just realized i'd cross posted and screwed up the status.

Island Usurper’s picture

Issue tags: +Release blocker
Island Usurper’s picture

Status: Active » Fixed
FileSize
1.43 KB

There's an API page on ubercart.org now, and I've just committed the patch to docs.php. I suppose that should be named api.php already, but that's not too important yet.

Status: Fixed » Closed (fixed)
Issue tags: -Release blocker

Automatically closed -- issue fixed for 2 weeks with no activity.