gps_gpslatitude and gps_gpslongitude are unfilled

Hi,
It seems gpslongitude and gpslatitude are left unfilled because of an issue with the type of data : a string is expected but an Array is passed.
Same issue with stable 6.x-1.2 version.
See also : http://drupal.org/node/395836

For a pseudo patch see #3.

In exif.module,
line 116, under
$tmp = $node->$field_name;
add

if ($key == 'gps_gpslatitude') {
            $value = _exif_DMS2D($value, $data['gps_gpslatituderef']);
            }
            elseif ($key == 'gps_gpslongitude') {
            $value = _exif_DMS2D($value, $data['gps_gpslongituderef']);
            }

line 255 : replace
if ($key == 'gps_latitude') {
with
if ($key == 'gpslatitude') {
line 256 : replace
$value = _exif_DMS2D($value, $data['gps_gpslatituderef']);
with
<$value = _exif_DMS2D($value, $data['gpsgpslatituderef']);
line 258 : replace
<if ($key == 'gps_longitude') {
with
<if ($key == 'gpslongitude') {
line 259 : replace
<$value = _exif_DMS2D($value, $data['gps_gpslongituderef']);
with
<$value = _exif_DMS2D($value, $data['gpslongituderef']);
With these editions, things seem OK : the Exif admin menu shows GPS data and not the word "Array", latitude and longitude are displayed in CCK fields and the "-" is added when required (CCK fields for latitude reference (gpslatituderef) and longitude (gpslongituderef) reference have to be set up for the content type).

please post a patch against the 6-1 version

Here it is.

This patch looks weird... the piece of code you insert is called later on in nodeapi

Indeed.
But, on my system, without the first part, insertions (from node data) in database fail with SQL warnings/errors.
And the second one is required here to have Long/Lat values displayed in the test page (at least).

subscribing

Powered by Dreditor.

+++ exif.module.patched	2010-01-26 07:25:13.000000000 -0400
@@ -114,10 +114,17 @@ function exif_nodeapi(&$node, $op, $teas
+            }

This part is only needed because the reformat function is called with different sets of data. When called from the admin/settings page, the gps fields look like "gpslongitude", when called during saving the node, they look as here. This is why the reformat function doesn't act on these fields.

+++ exif.module.patched	2010-01-26 07:25:13.000000000 -0400
@@ -114,10 +114,17 @@ function exif_nodeapi(&$node, $op, $teas
+            if (in_array($key, $date_array)) {

Please don't destroy the formatting.

+++ exif.module.patched	2010-01-26 07:25:13.000000000 -0400
@@ -252,11 +259,11 @@ function _exif_reformat($data) {
+    elseif ($key == 'gpslongitude') {

This fixes the admin/settings page but doesn't help node_save.

This patch needs some work, maybe I find some time.

Powered by Dreditor.

Here is a patch that works for me.

Hunk #1 FAILED at 103.
Hunk #2 succeeded at 266 (offset 77 lines).
Hunk #3 succeeded at 275 (offset 77 lines).
Hunk #4 FAILED at 320.
Hunk #5 succeeded at 332 with fuzz 2 (offset 66 lines).
Hunk #6 succeeded at 366 (offset 66 lines).

can you check this again? Applied patch against 6--1

Yeah, I started from the released version, my mistake.

I've seen that the dev branch has a exif-location module, should the gps stuff go in there. I am not fond of location.module...

Lets keep the location.module where it is and put the GPS stuff in the main module. I haven't really looked at the location module. I just put it in there, so it can be tested. Probably it would make though sense to get it all into one...

I've tried the patch at #5 and also the latest dev version of the module with the "Exif Location" module.

Both work for me, however in both cases, when the longitude is "west", the value is not being set as negative.

Can anyone help with this?

New patch with only the index name fixes, as this is the focus of this issue.

Please ignore last patch. The ref fields are not named correctly.

New patch for just the gps fields. Though @killes approach of standardizing the arrays is a better approach.

patch seems pretty simple. Can anybody else confirm the patch?

Yes, patch works for me.

anybody else? I'll commit it with one or two more people confirming the patch

Yep, patch working for me. Please commit :D

yeah, works. please commit. Thanx!

... give me to the end of the week

:) ... this patch is already in the dev version...