Unit testing [#395852]

Comment	File	Size	Author
	openid_provider_test.patch	3.58 KB	Aron Novak

Comment #1

anarcat CreditAttribution: anarcat commented 9 March 2009 at 15:58

Title:

Functional testing

» Unit testing

Isn't this more unit than functional tests?

What coverage are we aiming at now?

Log in or register to post comments

Comment #2

Aron Novak

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 10 March 2009 at 10:32

Sorry, i wrote nonsense, these are unit tests, not functional tests, of course :)
Coverage, well, i tried to test as many places as possible, some functions cannot be really tested because of the lack of the client part.

Log in or register to post comments

Comment #3

anarcat CreditAttribution: anarcat commented 11 March 2009 at 03:57

Well, that was what i was wondering: can we test the client part? There are things like http://openidenabled.com/resources/openid-test/diagnose-server/ that can do that...

Log in or register to post comments

Comment #4

Aron Novak

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 11 March 2009 at 10:22

Well, i think this is a problematic question. This means that you
1) could not test without network connection (however it's not common, but possible, servers behind strict firewall)
2) tests will fail if network fail - you have to find out where is the problem

Log in or register to post comments

Comment #5

anarcat CreditAttribution: anarcat commented 12 March 2009 at 22:45

Well, tests could be local: we could use the openid.module to do tests against the openid_provider.module. It would be hard because you have to reproduce the behaviour of the web browser but it's possible.

I don't think this idea should block this patch however, which looks nice to me (but I haven't tested it).

Log in or register to post comments

Comment #6

anarcat CreditAttribution: anarcat commented 23 June 2011 at 14:48

Status:

Needs review

» Needs work

I have committed the patch, but it needs some more love. First there's already a test that fails, maybe because of recent changes to the code:

DH public has correct length.	Other	openid_provider.test	65	OpenIDProviderTestCase->testOpenIDProviderDHAssoc()

Second, there are a bunch of warnings like this:

Starting run with db_prefix simpletest767840	System	openid_provider.test	10	OpenIDProviderTestCase->setUp()	
Table 'idorangeseedsorg.simpletest767840variable' doesn't exist query: UPDATE simpletest767840variable SET value = 's:4:\"/tmp\";' WHERE name = 'file_directory_temp'	User warning	database.mysqli.inc	135	_db_query()	
Table 'idorangeseedsorg.simpletest767840cache' doesn't exist query: DELETE FROM simpletest767840cache WHERE cid = 'variables'	User warning	database.mysqli.inc	135	_db_query()

... every time a test is setup.

Log in or register to post comments

Comment #7

anarcat CreditAttribution: anarcat commented 28 January 2012 at 20:47

Note that I have submitted a few tests upstream to Drupal core's functions. See #1419768: import tests from openid_provider module for followup.

I guess the next step here would be to test logins...

Log in or register to post comments

Comment #8

anarcat CreditAttribution: anarcat commented 17 November 2012 at 17:27

Status:

Needs work

» Fixed

let's close this for now, unit tests exist, they need to be expanded, but we can work on that later, it's not a blocker for anything, and people wishing to scratch an itch will do so.