When you enter a log message for node revisions, the entry is not carried over to preview. Issue was that default value was not set on the form element.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 394256_node_revlog_default_value_03.patch | 986 bytes | senpai |
| #4 | 394256_node_revlog_default_value_02.patch | 3.77 KB | cwgordon7 |
| #2 | 394256_node_revlog_default_value.patch | 986 bytes | senpai |
| node.pages-D6.patch | 427 bytes | Anonymous (not verified) |
Comments
Comment #1
senpai commentedMoving to 7.x-dev.
This logic flaw presented itself during the Documentation Sprint at Drupalcon D.C. while users were attempting to edit Handbook pages that now require a Log Message due to a drupalorg.module form alter. The string that a user entered into the log message did not propagate all the way through the form's validation and return due to the fact that there is no #default_value on the input element.
Comment #2
senpai commentedPatch attached. Working on test for it right now.
Comment #4
cwgordon7 commentedPatch with test attached. There was some very very very weird stuff going on in the node preview test, so I added comments in the attempt to spare the next person attempting to debug these tests. ;)
Comment #5
senpai commentedHere's a backport for D6 too, since this problem only rears it's angry head on d.o
Comment #7
cwgordon7 commentedThe "latest" test patch was for d6, so it's understandable that it didn't apply against HEAD, so marking back to needs review.
Comment #8
senpai commentedBumping, and fixing a mis-spelling in the title.
Comment #9
desbeers commentedThis is fixed in #385602: Log message is lost on node preview Patch in that issue is committed to HEAD and has a patch attached now for Drupal 6.
Comment #10
senpai commentedWoo hoo! Forward Progress FTW! Thanks for the info, desbeers.