Closed (fixed)
Project:
jCarousel Lite
Version:
5.x-2.0-alpha2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
7 Mar 2009 at 09:30 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent
Comments
Comment #1
owahab commentedHello notabenem,
Thank you for your support and contribution.
However, the above patch fails 100%.
Please generate a patch using this how-to: http://drupal.org/patch/create.
Comment #2
owahab commentedI have applied your changes manually.
Thank you for the patch and for your contribution.
Comment #3
notabenem commentedHi Omar,
Sorry for the bad diff... works for me though. I've noticed that the readme for 6.x is a bit outdated and I forgot to change it. Maybe it could make it more up to date, especially the dependencies part.
Comment #4
owahab commentednotabenem,
The port didn't handle the views integration, I should be working on this next week unless you plan to do it.
Comment #5
notabenem commentedOmar,
My primary goal was to make the basics working under d6.x. Although I updated some parts of the views integration module to be "compatible" with 6.x, I did not check whether it is actually working with views 2.x as I had no plans using that part.
Therefore, please do!
Comment #6
marcoka commentedit is NOT working. the following code from the jcarousellite.module is not embedded so it does not work.
<?php
// $Id: jcarousellite.module,v 1.3 2009/03/07 21:05:23 owahab Exp $
/**
* @file
* jCarousel Lite is a jQuery plugin that carries you on a carousel ride
* filled with images and HTML content. Put simply, you can navigate
* images and/or HTML in a carousel-style widget. It is super light weight,
* at about 2 KB in size, yet very flexible and customizable to fit most
* of our needs.
*/
function jcarousellite_add($data = NULL) {
static $added;
if (!isset($added)) {
drupal_add_js(drupal_get_path('module', 'jcarousellite') .'/js/jcarousellite.js');
drupal_add_js(drupal_get_path('module', 'jcarousellite') .'/js/jquery.easing.js');
drupal_add_js(drupal_get_path('module', 'jcarousellite') .'/js/jquery.mousewheel.js');
$added = TRUE;
}
if ($data) {
drupal_add_js($data, 'inline', 'footer', FALSE);
}
}
Comment #7
everjohnson commentedHow should I put thiese code in the file? I paste it into jcarousellite_views.module, but failed.
Comment #8
owahab commentedD6 Beta 2 now works fine with Views 2.0.
Please open a new issue if this feature doesn't work.