It looks like the exclude books settings only work for new books, not for existing books that are resaved. To reproduce, set a custom AdvancedBookBlock to 'New books are disabled by default' or 'Automatically exclude books with selected terms' and set a few terms to exclude. Then create a new book. This book should be excluded by default. But if you go in and resave this book, it will be automatically added to your custom block.

Comments

PixelClever’s picture

PixelClever commented
Status: Active » Closed (works as designed)

I'm afraid this is by design. Before it was set up so that edits were also processed, but the problem with this was that any time a book was edited it was removed from the block. I think this was worse. There might be a way to have your cake and eat it too, but I haven't thought of it yet. You are welcome to submit a patch if you think of a solution.

PixelClever’s picture

PixelClever commented
Category: bug » task
Status: Closed (works as designed) » Active

On second thought... I would like to see this working better so I am setting it to active.

mshaver’s picture

mshaver commented

I guess from my usage standpoint it's much more important to have books excluded by default and only added by opting in. I can see the use case for the other side as well though. I'll take a look at the code, but I'm sure you are more familiar with how this should work. Thanks for the great module.

PixelClever’s picture

PixelClever commented

I think the solution is going to be to add the option to lock a block completely from having elements added or removed no matter what.

PixelClever’s picture

PixelClever commented
Status: Active » Fixed

I added an option to lock the block to all additions in 1.6.

mshaver’s picture

mshaver commented

The lock bock code works great. I did notice another bug that I hadn't seen before, so I'm not sure if it was introduced with the fix? I'll fill another issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.