Currently, if you turn off the 'allow custom thumbnails' for a field, it still appears on the edit form. We need to respect the setting. However, we'll also need to make sure we still read thumbnails if it's been turned off for a field, because of how it's tied into remote thumbnails now.

Also, even if the form's not displayed, we still need to capture and store remote thumbs when that's allowed.

CommentFileSizeAuthor
#3 emthumb-377744.patch1.93 KBandrewlevine

Comments

alex ua’s picture

alex ua commented
Status: Active » Needs review

We need to check and see if this has been fixed by the emthumb issues.

andrewlevine’s picture

andrewlevine commented
Status: Needs review » Active

This has actually not been fixed...will try to get a patch for this next week.

andrewlevine’s picture

andrewlevine commented
Status: Active » Needs review
StatusFileSize
new emthumb-377744.patch1.93 KB

There are 4 permutations based on two field settings ("Store remote thumbnails for this field" and "Allow custom thumbnails for this field") in which emfield should act differently. 3/4 were functioning properly. Patch fixes behavior

1. Neither is checked. Emthumb does nothing. Already working
2. Both are checked. Emthumb will download remote thumbnail and store it unless a custom thumb is uploaded. Already working (But I added a blurb in the fieldset that explains this behavior)
3. Just store remote thumbnails. Emthumb will download remote thumbnail if available. This was confusing because an empty fieldset would be displayed if there was no thumbnail available. (But I added a blurb in the fieldset that explains this behavior).
4. Just custom thumbnails (not remote). Already working

andrewlevine’s picture

andrewlevine commented

Actually I believe case 1 would display an empty fieldset also...but the patch takes care of that too :)

aaron’s picture

aaron commented
Status: Needs review » Fixed

committed. thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.