Right and Left are incorrect, because in RTL languages the sidebars should change sides. I've renamed them to primary and secondary.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | rtl-sidebar-names-375953-6.patch | 14.99 KB | johnalbin |
| #6 | rtl-sidebar-names-375953-6.patch | 14.99 KB | johnalbin |
| #2 | rename_sidebar_to_be_rtl_1.patch | 10.41 KB | amitaibu |
| rename_sidebar_to_be_rtl.patch | 9.77 KB | amitaibu |
Comments
Comment #1
amitaibuAdd 'RTL' tag.
Comment #2
amitaibuForgot the zen.info file.
Comment #3
amitaibubtw, depends on #283978: RTL support for IE stylesheets
Comment #4
johnalbinInterestingly, Layout Studio uses Secondary and Tertiary as the names of the sidebars. Presumably, this is because the main content is the "primary" source of content. :-\
I'm glad you left the variables as $left and $right since Drupal treats those variable names specially.
Amitai, I apologize for not getting to these RTL issues sooner! Things have been crazy busy for me. But I want these RTL issues to be one of the first things I get to for Zen 6.x-2.x.
Comment #5
amitaibu>> Amitai, I apologize for not getting to these RTL issues sooner!
No problem, if you need me, I'm still around :)
Comment #6
johnalbinHere's an updated patch that fixes a couple of minor things.
Comment #7
johnalbinTrying to attach the patch again.
Comment #8
johnalbinOk. I've committed this patch.
However, I'm going to be tracking the Drupal 7 issue for #226587: Default sidebar region labels are confusing (wrong) for RTL languages and if that issue decides to use a different naming scheme for D7's sidebars, I'll use those names.
Thanks, Amitai!
Comment #10
johnalbinGiven the recent discussion in #226587: Default sidebar region labels are confusing (wrong) for RTL languages, I'm going to change the sidebar names from primary/secondary to first/second.
Comment #11
johnalbinOk, the changes have been committed. I hope I got everything.