When imagemagick crop is called it adds a '+' in front of both the x and y offsets even when the supplied integers may be negative. This results in a +- set for the offset in the crop geometry and in certain versions of imagemagick that makes it tile the output image creating multiple files, none of which has the right filename (it tags on a -0 and -1 to the filenames).

The same exact issue has been reported in the imagecache issue queue here.

The attached patch just throws in some logic for wether it should be a '+' or a '-'.

CommentFileSizeAuthor
#3 imagemagick-HEAD.crop-negative.3.patch1023 bytessun
#2 373759-sign.patch894 bytesandypost
image.imagemagick.inc_.patch748 bytessarvab

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Project: Image » ImageMagick
Version: 6.x-1.x-dev » 7.x-1.x-dev
Component: imagemagick toolkit » Code

Moving to ImageMagick project.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 373759-sign.patch894 bytes

re-roll a bit different

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new imagemagick-HEAD.crop-negative.3.patch1023 bytes

Thanks for reporting, reviewing, and testing! Committed attached patch to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.