in:

/includes/database/mysql/database.inc

on line 18, line is

$this->transactionSupport = !empty($connection_option['transactions']);

and should be

$this->transactionSupport = !empty($connection_options['transactions']);

($connection_option -> $connection_options).

this preveents transactions from being enabled since it always returns false

CommentFileSizeAuthor
#3 drupal-7-dev-373514-1.patch595 bytesjbomb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Hm, right you are. Can you roll a quick patch?

karschsp’s picture

Issue tags: +Novice

Tagging for novice queue.

jbomb’s picture

FileSize
595 bytes

requested patch from #1 with jaydee18's fix

jbomb’s picture

Status: Active » Needs review
Crell’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks!

Dries’s picture

It looks good to me, but I wonder why the tests work without this patch ... should we look at fixing our tests?

Crell’s picture

The test bot only runs MyISAM right now, so it's not actually testing transaction logic. Known issue, has not yet been solved, but not something we can solve in this patch.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.