Documentation addition for API doc on user_save()

Here is a patch that clarifies the doc (for 7.x)

Here's a patch for 6.x too.

I meant that second patch to have a .txt extension so it wouldn't automagically be applied. How can I change this or delete that attachment? Anyway, the doc sprint is wrapping up.

Changing this to 7.x, since it is a 7.x issue as well.

Here's a new 7.x patch that should apply now. Will port to 6.x when it passes review.

Forgot to change status

Setting to previous status - testbot was broken (failed to install).

Setting back to Needs Review in hopes that the patch will get retested. The test bot was apparently malfunctioning (I had about 7 patches fail in that time period, all were doc, none broke the HEAD install I am pretty sure).

Seems like the $user->is_new == TRUE bit got cut. I am fond of that part.

Good point. How is this patch?

Actually, I think this one is better.

The wording for $account is still confusing IMO.

OK. I'll give it another try on Monday. Brain rather fried today. Suggestions welcome. :)

How about this version?

WFM

Committed to HEAD, thanks!

Needs backport to 6.x methinks. 6.x does not have that ->is_new parameter afaik, so that part should be dropped.

Here is a patch for Drupal 6.

Try this one. Typo in the first one.

This basically matches the D7 doc (except the parts that don't apply), so I'm just going to set this to RTBC.

I think this does not explain how can $account be omitted.

OK, how's this?

bump. This patch still needs a review. I just noticed on another issue how bad the current doc is for user_save()... Can someone please review this? Thanks...

The content of the patch looks good to me (a big improvement over what's there now). The patch was created before the git conversion, so doesn't apply. I've re-rolled it.

OK, we have two +1 votes (mine and jn2) on the content of the patch -- thanks for the re-roll! Let's get this in.

Thanks, committed.