Option to open Page Link in a new window and Lightbox2 module integration

How do you add this to your legal module?

I am still a little bit confused...do I save the file, if so what do I save it as?
Thank you

Hello,
Valery, if you want to patch your module, you have to save the patch in the good directory (here, the "Legal" module directory).

Then you navigate through the "cd" command to the good directory (i.e. "cd www/mywebsite/sites/all/modules/legal"), and you apply the patch.
To do this you have to type : "patch [-b] < your_patch_file.patch".

(the "-b" option creates a copy of your file before modifying it, can be useful).

Is there a way create a pop-up window with only the terms and conditions?

Menu's etc. should not be there...

is it possible to integrate the "popup api" module with the legal module?? instead a new window but just "overlay".

I am quite new this drupal thing, and trying to read the readme.txt from popup api module, and seems shouldn't be hard to integrate them both ?? for the experience users, but just no clue what it is saying there.

would be appreciated if u can point me to the right direction.

foodbo good idea!

I've been wanting to add a Lightbox style effect rather than link to another page, and this looks like an easy way to do it.

I don't have time to do it at the moment, but it's high on my To Do list.

What is the status of this? Did it get incorporated as I'm looking for a feature like this.

Roberto, I would be interested to know if you had a look at the lightbox-style effect - this would be ideal, rather than using a new window.

Phil

I'll look into this next week. Will be doing a clean out of all issues of Legal module.

I wrote a quick form alter so I didn't have to patch the module to hold my client over until this is rolled into CVS.

Toss this in a custom module:

function MODULENAME_user_form_alter(&$form, &$form_state, $form_id) {
  switch($form_id) {
    case 'user_register':

      //uncomment this to dump the fapi for the legal checkbox
      //print '<pre>';
      //print_r($form['legal']['legal_accept']);
      //print '</pre>';
    
      if ($form['legal']['legal_accept']['#title'] == '<strong>Accept</strong> <a href="/legal">Terms &amp; Conditions</a> of Use') {
        $form['legal']['legal_accept']['#title'] = '<strong>Accept</strong> <a href="/legal" target="_blank">Terms &amp; Conditions</a> of Use';
      }
      break;
  }
}

You could also use this to add an overlay, since you can modify the a tag and add say a rel="[lighbox]" or something like that.

original patch no longer applies cleanly.

Here's an updated patch against 8.x dev.
Additionally, this adds an option for the admin to choose whether to use target="_blank" or XHTML-compliant rel="external"

ctools modal would be a way too.

I guess the modal/lightbox concept got thrown out? It was mentioned back in Sept of 2010 that this was a good idea but still in v7, it is still not present? Almost all other sites that you see a "Terms of Service" link, it opens in an overlay so that you don't get taken away from the registration page... why has this not been accomplished yet?

I was able to make a simple change to the legal.module file, to include a lightbox call but it loads the entire page (with menus, etc) and not just the TOS text...

legal module has a lof of more important code issues than adding new features :)

Inspired by #13, I wrote a quick little module to open the Terms & Conditions link in a new window:

function MODULENAME_form_user_register_alter(&$form, &$form_state) {

      if ($form['legal']['conditions']['#value'] == ' ') { 
        $form['legal']['legal_accept']['#title'] = t('<strong>Accept</strong> <a href="/legal" target="_blank">Terms &amp; Conditions</a> of Use');
      };
}

This isn't checking the contents of the title string, instead it's checking for the part of the conditions array as set in the 3rd case in the legal preview function in legal.admin.inc. It's also using the correct form ID. :)

Xstatic, could you tell me what lines you edited in the legal module to make colorbox show up? The full page is livable for now for me.

Any news about this?

#21 doesn't work for me.

Temporally solved this using jQuery:

jQuery('#user-register-form a[href="/SUBFOLDER/legal"]').attr('target','_blank');
jQuery('#contact-site-form a[href="/SUBFOLDER/legal"]').attr('target','_blank');

Note: second line is about #804592: T&C for contact form - Comment #4

I vote for this feature!

warmth - where did you put this?

Thanks in advance,
Julie

@spyderpie, within one of my js files loaded with my custom theme.

fixed Drupal 7 Version of #21:

function mymodule_form_user_register_form_alter(&$form, &$form_state) {
  if (isset($form['legal']['legal_accept']['#title'])) {
    $form['legal']['legal_accept']['#title'] = t('<strong>Accept</strong> <a href="@terms" target="_blank">Terms & Conditions</a> of Use', array('@terms' => url('legal')));
  };
}

make sure to update the translation for that string, since it differs from legal module's one.

What's the status of getting a fix into the Legal module?

Since the user registration form itself is modified via hook_form_user_register_form_alter() you may have to use hook_module_implements_alter() or change module weights to make sure your code comes later if checking for an existing field.

In my case I sucked it up and added target="_blank" directly to the link in theme_legal_accept_label(). If a configuration option was ever decided on when Drupal 14 comes out in 2025 I would make opening a new window opt-out rather than opt-in to be consistent with current trends (you can even add rel="nofollow" while you're there for SEO purposes).

Hi, I add in template.php into /themes,
a small change in code #21 and it's worked for me.

function mythemes_form_user_register_form_alter(&$form, &$form_state, $form_id) {
  if (isset($form['legal']['legal_accept']['#title'])) {
      $form['legal']['legal_accept']['#title'] = t('<strong>Accept</strong> <a href="/legal" target="_blank">Terms &amp; Conditions</a> of Use');
      };
}

Hello,
#21 thanks for quick fix. I managed to configure Lightbox2 module by using following code.

function mythemes_form_alter(&$form, &$form_state, $form_id) {
  if ($form_id == 'user_register_form') {
	if (module_exists('lightbox2')){  	
	  	if (isset($form['legal']['legal_accept']['#title'])) {
	      $form['legal']['legal_accept']['#title'] = t('<strong>Accept</strong> <a href="' . url("legal") . ' #content" rel="lightmodal">Terms &amp; Conditions</a> of Use');
	    };
	}
  }
}

This weekend I'll try to Integrate Lightbox2 module with Legal module.

Patch to integrate Lightbox2 module and optional field to open page link into new window.

Please take a look.

Forgot to delete variables. Here is the new patch. Thanks

Thanks to everyone who worked on this patch!

I've added it to the 7.x-1.x-dev branch with some changes:

* Made the link target checkboxes into one radio field that is displayed dynamically if Link is selected as the Display Style
* Simplified and generalized the code so other modal dialog modules can be easily added
* Moved the Display settings below the T&Cs text field for a neater form

Bytheway, the out of the box styling of T&Cs in the Lightbox2 modal is horrible.

If anyone wants to provide a patch with some styling it would be very welcome!