Flush deleted messages

Removed the COUNT(), only used that to test it, it isn't needed...

Oh, yes of course. Will update the patch..

Removed the debug message... it was late...

I found out that it wasn't working on PostgreSQL yet. The issue is the count query in combination with GROUP BY and HAVING. I wrote a function which generates a special $str_select with only aggregate functions and subqueries. Those that are probably needed in HAVING. It's not possible to add all fields, because the group by is missing, so postgresql bails out.

It's not perfect...
- A query with HAVING without GROUP BY wouldn't work, but we don't have them yet..
- A HAVING statement which would use a non aggregate field would not work..

However, it really gets complicated, so I would suggest to only implement support for those features if we actually need to use them.

TODO: Add hook_privatemsg_message_flush and remove $deleted_by_all

Updated:

- added new hook_privatemsg_message_flush
- removed $deleted_by all related code
- Added a configurable flush maximum per cron run, defaults to 200 (takes 1,3s on my pc)

Forgot to update the status

And forgot to add the update hook, thanks nbz!

PostgreSQL fixes:

- use php's date() in the update hook, pgsql doesn't know unix_timestamp()
- use MAX/MIN in HAVING, pgsql can't handle the aliases

Next try, slight improvements of the wording.

- To make sure this works correctly, I added some tests. The test creates 10 new messages, deletes a different sub-group of them for author and recipient, overwrites the deleted timestamp for some of the deleted messages and then checks if the messages are still there or if they have been flushed.

- While writing the patch, I noticed that _privatemsg_load does not check if the message exists at all. If it does not exist, a array with only the user key set is returned. That does not make sense, so I changed it to return FALSE if no message has been found. node_load for D6 and 7 does the same thing.

- Removed a debug statement in privatemsg_cron()

Re-roll, changes:

- updated privatemsg_message_change_delete. $delete parameter should now be TRUE/FALSE and is passed down to the delete hook.
- re-included the count changes in nbz's inbox patch. I need to do more performance checks as I can't get MYSQL to stop sorting that *** subquery, but it works great.
- updated tests

Removed query builder stuff...

Re-rolled, all tests pass again and improved some inline docs.

+++ privatemsg.install	12 Sep 2009 05:39:28 -0000
@@ -417,4 +417,16 @@
+function privatemsg_update_6004() {

Once again, that needs to be updated, we are now at 6006 :)

+++ privatemsg.test	12 Sep 2009 05:39:28 -0000
@@ -110,6 +110,58 @@
+      privatemsg_new_thread(array($recipient), 'Message #'. $i, 'This is the body',array('author' => $author));

Really minor, there is a space missing before the second/last array.

Can you fix these two things and then we can finally commit and close this issue? :) It does have (imho quite well) tests and has been tested manually extensively on both mysql and pgsql.

This review is powered by Dreditor.

Yeah!

Added to 6.x-1.x-dev and 7.x-1.x-dev!

Note that the D7 Port contains a few necessary changs to theme() calls since I only got fatal errors without these which made it quite hard to test...