Hello,

As per subject, I noticed only those nodes are included in the table that were created after the module was installed.

Does this mean, that nodes created before wont be able to receive trackbacks?

Cheers,
G

CommentFileSizeAuthor
#3 trackback-370660.patch1.5 KBCybergarou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cybergarou’s picture

Assigned: Unassigned » Cybergarou
Category: support » bug

I also noticed this. The table only contains nids for nodes created or modified after the module was installed. I ran a test and determined that you can receive trackbacks even if the old node the trackback is sent to isn't in the table. So from that angle, this isn't a problem.

I will have problems with this though. I'm working on a patch to add views support to the trackback module. Since nid is used to connect trackbacks to the nodes, the missing entries will produce incorrect results or even errors in some instances. I would prefer to keep this table in the mix of what will be available in views so I can do neat things like indicate trackbacks waiting for cron.

Solving this should be pretty simple so I'll add it to my list of things to do when I get back next week.

thePanz’s picture

Thank you for joining this issue. I've been busy in latest months and I have some projects on the way for next weeks.
Feel free to post a patch/suggestions/code for Trackback module, I'll commit your changes for you.
Thanks

Cybergarou’s picture

Status: Active » Needs review
FileSize
1.5 KB

Here's a patch to make sure the trackback_node table is complete.

With this patch, existing nodes are added during installation. For existing installations, the missing nodes are added through an update.

Just a note here, this patch isn't needed to make the Trackback module work correctly the way it is now, but it is required for the patch I'm working on to add views support.