Previewing HEAD release nodes is broken in 6.x [#370603]

A) While testing edge cases of #369889: New release nodes loose version string and project association I noticed an annoying problem with the crazy multi-page release node form if you're creating a release from HEAD. Once you get to the final page, if you preview, it sends you back to the 2nd page of the form where you're supposed to select the version elements. :( I'm seeing this both locally and on d6.d.o.

It's not that critical if this is broken when we first go live, so I'm not marking it relevant to the d.o upgrade, but I wanted to open an issue about it so I don't forget it.

While we're at it, a few other semi-related bugs:

B) If you edit a HEAD release node and move the branch to something else, the new branch isn't saved with the release node.

C) While creating a new HEAD release node, on page 2 (version selection), if you keep previewing, you lose the values in the form.

D) While creating a new HEAD node, if you select some release type terms, but don't fill in the release notes, and preview, you lose the taxonomy terms on the validation error.

Comments

Comment #1

dww

we/he/they

commented 8 February 2009 at 08:09

In the car on the way home from a gig tonight, I had a flash of inspiration about bug (A). The problem is that we were calling this:

   unset($form_state['storage']['project_release']);

from $form['#submit']. Since that's called for both preview and save, when we previewed, we cleared out the storage, and then the form got confused. Now, I split that off into a separate handler that's only attached to the real "save" button, and it works as expected:

http://drupal.org/cvs?commit=169966

B-D are still broken, so I'm leaving this active, but at least the worst of the bugs is now dead. ;)