The vocabulary edit form suffers from over-fieldset-use.

  • The Information fieldset contains the essential Vocabulary name field. This patch removes the fieldset, the name should be upfront.
  • Help and Description are reordered. Description probably is not used anywhere in core and not important.
  • The Content types fieldset was redundant, it's gone.

And some code style is fixed. Tests updated.

CommentFileSizeAuthor
#4 Taxonomy | Drupal 7.x_1233603195188.png103.23 KBdrumm
#2 taxonomy.diff5.15 KBdrumm
Taxonomy | Drupal 7.x_1233531789674.png91.94 KBdrumm
taxonomy.diff4.67 KBdrumm

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy.diff5.15 KB

Removed weight from forum test. Weight is removed because the main admin page has reordering and weight makes no sense out of context.

dries’s picture

dries commented

Neil, it would be great if you could do a before and after shot. :-)

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new Taxonomy | Drupal 7.x_1233603195188.png103.23 KB

Before shot attached. After is in the original issue here.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Screenshot, +Needs usability review

This is a good clean up IMO, and turning the description into a text field instead of textarea makes it look a lot less foreboding. Updating tags.

dmitrig01’s picture

dmitrig01 commented
Status: Needs review » Reviewed & tested by the community

Looks great IMO. Tested, code is good.

yoroy’s picture

yoroy commented

Obvious improvements, nice clean up. +1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Great work! Committed to HEAD. :)

Status: Fixed » Closed (fixed)
Issue tags: -Screenshot, -Needs usability review, -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Screenshot, +Needs usability review, +Usability

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.