Before _workflow_write_history() is called $node->workflow_stamp needs set so that a timestamp is stored along with the message and also so notices are not thrown like 'notice: Undefined property: stdClass::$workflow_stamp'.

Attached is a patch to fix where this is missing in hook_nodeapi's delete. It also contains whitespace cleanup.

CommentFileSizeAuthor
#1 workflow_stamp.patch673 bytescyu
workflow_stamp.patch2.81 KBcyu

Comments

cyu’s picture

cyu commented
StatusFileSize
new workflow_stamp.patch673 bytes

Here a patch without the whitespace cleanup, showing that it is just 1 line needing added, for HEAD, since it also needs fixed there.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

+1. I'm getting this PHP notice using drush to mass delte nodes. The patch fixes this... Why is not commited yet?

jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Fixed

Committed. Will appear in 6.x-1.5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.