Generated with the help of an LLM.

Problem/Motivation

Core deprecated annotation discovery in drupal:11.3.0, so drupal.org CI's phpunit jobs report a deprecation for each of these plugins, removed from drupal:13.0.0 (https://www.drupal.org/node/3395575):

  • EntityEmbedFilter: @Filter
  • EntityEmbedFakeEntity: @ContentEntityType
  • Plugin\EmbedType\Entity: @EmbedType
  • Plugin\CKEditor5Plugin\DrupalEntity: @CKEditor5Plugin

Entity Embed now requires Drupal ^11.3 and Embed ^1.12, which have the matching attributes.

Proposed resolution

Replace each annotation with its attribute: #[Filter], #[ContentEntityType], #[EmbedType] and #[CKEditor5Plugin] (with CKEditor5AspectsOfCKEditor5Plugin and DrupalAspectsOfCKEditor5Plugin, keeping the deriver).

Entity Embed's own display plugins already use #[EntityEmbedDisplay] since #3554612: Not supporting attribute discovery. @CKEditorPlugin stays until CKEditor 4 support is removed in 2.0.x (#3639495: [meta] What to remove in 2.0.x).

AI disclosure

I used Claude Code to find the deprecated annotations and draft this summary; I reviewed the CI output and chose the scope.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dave reid created an issue. See original summary.

dave reid’s picture

Status: Active » Needs review

  • dave reid committed ca97e7e8 on 8.x-1.x
    fix: #3639506 Use plugin attributes and replace the stable9 theme in...

  • dave reid committed ca97e7e8 on 2.0.x
    fix: #3639506 Use plugin attributes and replace the stable9 theme in...