Problem/Motivation

This is a follow-up to #3634150: Tools menu link with route <front> becomes the active link on the front page since core #1578832 with merge request MR !226 and commit:
https://git.drupalcode.org/project/admin_toolbar/-/commit/63f337df01d3b1...

Which added file:
admin_toolbar_tools/tests/src/Kernel/AdminToolbarToolsFrontLinkTest.php

Which introduced PHPUNIT errors for builds:
3.6.x all builds - Every two weeks, phpunit previous minor: ❌
https://git.drupalcode.org/project/admin_toolbar/-/jobs/13715053

3.6.x Deprecation build on D9.5.x - Every month, phpunit: ❌
https://git.drupalcode.org/project/admin_toolbar/-/jobs/13711792

Steps to reproduce

Run pipeline schedules at:
https://git.drupalcode.org/project/admin_toolbar/-/pipeline_schedules

Proposed resolution

Fix the phpunit reported errors for the 3.6.x branch.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dydave created an issue. See original summary.

  • dydave committed a177f756 on 3.6.x
    Issue #3639317 by dydave: Fixed PHPUnit failures: 'InputBag' not...
dydave’s picture

Issue summary: View changes
Status: Active » Fixed

Quick follow-up on this issue:

The two failing jobs of the scheduled pipelines on the 3.6.x branch were caused by two different problems:

  • phpunit (9.5.x): AdminToolbarToolsFrontLinkTest (added in #3634150: Tools menu link with route <front> becomes the active link on the front page since core #1578832) used Symfony\Component\HttpFoundation\InputBag, which does not exist in Symfony 4.4 (Drupal 9.5), causing Class "Symfony\Component\HttpFoundation\InputBag" not found. It was replaced with ParameterBag.
  • phpunit (previous minor): AdminToolbarToolsExtraLinksTest failed randomly when a generated bundle ID contained digits (e.g. f25zk6nm): the test sorts the IDs with sort(), while the menus are sorted with natural order (strnatcasecmp()), so the expected links order did not match. The random bundle IDs are now generated with letters only.

 
The pipeline of the merge request passed, including the Drupal 9.5 and previous minor jobs, so I went ahead and merged MR !233 into 3.6.x.

Marking this issue as Fixed. The next scheduled pipelines on 3.6.x should confirm that the jobs are green again.

Thanks in advance!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.