Generated with the help of an LLM.

Problem/Motivation

drupal.org CI's phpstan job now fails on 8.x-1.x with three errors. #3554612 covers the attribute discovery one; this issue covers the other two:

  • FieldFormatterEntityEmbedDisplayBase::build() calls the deprecated show().
  • DrupalEntityDeriver stores entity storage in a property (drupal.entityStoragePropertyAssignment).

Proposed resolution

  • Replace show($build[0]) with $build[0]['#printed'] = FALSE;, which is what show() does.
  • Keep the entity type manager in DrupalEntityDeriver and call getStorage('embed_button') in getDerivativeDefinitions().

The Project Update Bot's MR in #3610147 has the same show() fix, but it targets 2.0.x and includes unrelated changes.

AI disclosure

I used Claude Code to find the existing issues and draft this summary; I reviewed the CI errors and chose the fixes.

Comments

dave reid created an issue.