Needs review
Project:
Commerce Core
Version:
4.x-dev
Component:
Payment
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Nov 2026 at 10:20 UTC
Updated:
18 Nov 2026 at 11:40 UTC
Jump to comment: Most recent
A few APIs were deprecated in commerce:3.0.0 for removal in commerce:4.0.0.
Remove:
Drupal\commerce_payment\Form\PaymentAddFormPaymentGatewayInterface::getJsLibrary(), replaced by getLibraries()js_library property of the CommercePaymentGateway annotation, replaced by librariesNone.
The deprecated APIs listed above are removed.
None.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jsacksick commentedPushed a first pass to the issue fork (branch
3638819-remove-code-deprecated) that removes:PaymentGatewayInterface::getJsLibrary()and thejs_libraryannotation/attribute property.librarieshas existed since 3.0.0, so a gateway can switch once and support both 3.x and 4.x.PaymentAddForm, along with thecommerce_payment_use_legacy_add_payment_formsetting and the route subscriber behind it. The route now points straight atOrderPaymentAddForm.I'm not sure about the second part yet. The form was marked deprecated in 3.0.0, but the setting that keeps it was only added in 3.3.0, so sites were told fairly recently that they could keep the two-step form. The alternative is to keep it in 4.0 and change the deprecation to removal in 5.0.0.
Leaving this open for feedback, particularly from anyone still using the legacy form. Moving on to #3638818 in the meantime.