Undefined array key "metadata" [#3637468]

Problem/Motivation

Warning: Undefined array key "metadata" in Drupal\Core\Menu\MenuLinkBase->getMetaData() (Zeile 105 in /var/www/web/core/lib/Drupal/Core/Menu/MenuLinkBase.php)

The menu definition is missing “metadata” and “parent”, but the MenuLinkBase class requires these two parameters in the corresponding functions getParent() and getMetaData().

Steps to reproduce

I found this error when using contrib module menu_item_role_access which uses MenuLinkBase->getMetaData()

Proposed resolution

add "metadata" and "parent" to menu_definition

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3637468

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3637468-undefined-array-key changes, plain diff MR !17778
Check out this branch for the first time

Check out existing branch, if you already have it locally