Problem/Motivation

Commit e275e88e Fixed cache contexts set in Views cache plugins. updated caching logic, but missed updating the - otherwise very simple - test at \Drupal\Tests\search_api\Unit\Views\SearchApiTagCacheTest::testCacheSetSkipsAbortedQuery.

Steps to reproduce

Look at CI or try to execute the test mentioned above.

Proposed resolution

Extend the test with further necessary mocks (and build a very simple service container)

Remaining tasks

Issue fork search_api-3637303

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

huzooka created an issue. See original summary.

huzooka’s picture

Assigned: Unassigned » huzooka
huzooka’s picture

Assigned: huzooka » Unassigned
Status: Active » Needs review

alorenc’s picture

Assigned: Unassigned » alorenc
alorenc’s picture

Assigned: alorenc » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch updates the existing unit test to match the reworked cacheSet(), which now reads the display's cache metadata and the query's cache context.