Problem/Motivation
Varbase Starter applies the Easy Email Express recipe. Easy Email Theme then takes the email logo from the default theme, Varbase Theme - Bootstrap 5, whose logo is logo.svg. About 24% of email clients tested by caniemail cannot show SVG, including Outlook for Windows 2007 to 2016 and Gmail webmail, so many readers get an email with no logo (the Gmail case is also #3554103).
Easy Email Theme is a hidden theme, so there is no settings form to change the email logo, and easy_email_theme.settings does not exist on a fresh install.
Steps to reproduce
- Install Varbase 11.0.x-dev with Varbase Starter 1.0.x-dev (Drupal 11.4.12, Easy Email 3.0.9, Easy Email Theme 1.1.0).
- Send an HTML email, for example a password reset.
- The logo is an SVG image. It does not show in Outlook for Windows or Gmail webmail. Mailpit's HTML Check flags it.
ddev drush config:get easy_email_theme.settingsreports that the config does not exist.
Proposed resolution
Ship config/easy_email_theme.settings.yml in the recipe with logo.use_default: false and logo.path: themes/contrib/vartheme_bs5/logo-email.png, the PNG added in #3637288.
It is a config file, not a config action: Easy Email Theme ships no default settings, and simpleConfigUpdate cannot create missing config. Recipes only create config that does not exist yet, so sites that already set a logo keep it.
Depends on #3637288 being released first. Until then the path points at a missing file and emails show no logo.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ❌ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- The logo shows in HTML emails in clients that cannot render SVG.
API changes
- N/A
Data model changes
- Adds
easy_email_theme.settingsconfig to the recipe.
Release notes snippet
- HTML emails now use a PNG logo that shows in Outlook and Gmail.
AI-Generated: Yes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | email-mr-01-png-logo.mp4 | 3.58 MB | rajab natshah |
| #4 | 01-logo-compare-img-src.png | 51.9 KB | rajab natshah |
| #4 | 01-logo-after-html-check.png | 94.35 KB | rajab natshah |
| #4 | 01-logo-after-email.png | 36.52 KB | rajab natshah |
| #4 | 01-logo-before-html-check.png | 158 KB | rajab natshah |
Issue fork varbase_starter-3637289
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahMR !90 is ready for review. It needs the PNG from #3637288 released first.
Comment #4
rajab natshahBefore and after evidence for !90, tested on Varbase 11.0.x with Varbase Starter (Drupal 11.4.12, local DDEV + Mailpit).
Before: the password reset email on Varbase 11.0.x with Varbase Starter 1.0.x-dev. The header logo is the theme's logo.svg.
Before: Mailpit's HTML Check lists 20 warnings, including SVG image format. A linked SVG image is not supported in about 24% of tested email clients (Apple Mail, Outlook for Windows, several Gmail versions) and partly supported in about 12% more.
After: the same email with the new logo-email.png (150 x 30 PNG). It renders the same, and more email clients can show it.
After: HTML Check lists 19 warnings. The SVG image format warning is gone; the remaining rows are the same as before.
The logo img src in the sent HTML: themes/contrib/vartheme_bs5/logo.svg before, themes/contrib/vartheme_bs5/logo-email.png after (set by Varbase Starter's easy_email_theme.settings.yml). Cropped from Mailpit's HTML Source tab.
Short walkthrough, about 40 s, voice only: email-mr-01-png-logo.mp4
Release order: vartheme_bs5 !257 in #3637288 first, since this MR points at the logo-email.png it adds.
AI-Generated: Yes
Comment #5
rajab natshahComment #6
rajab natshahComment #8
rajab natshah✅ Released in varbase_starter 1.0.10