Problem/Motivation
HTML emails on Varbase sites take the logo from the default theme, which is logo.svg. About 24% of email clients tested by caniemail cannot show SVG images, including Outlook for Windows 2007 to 2016, Outlook for macOS and iOS, and Gmail webmail. Those readers see no logo.
The theme also ships logo.png, but it is 143×32 and does not match the current logo.svg (150×30).
Steps to reproduce
- Install Varbase 11.0.x-dev with Varbase Starter 1.0.x-dev.
- Send any HTML email (for example a password reset) and open it in Outlook for Windows or Gmail webmail.
- The header has no logo.
Proposed resolution
Add logo-email.png: logo.svg as a 150×30 PNG, the same displayed size as the SVG. The Easy Email Theme template sets no width on the logo, so a 2x image would show at double size and dominate the header. The README says what the file is for.
Varbase Starter then points the email logo at it (see Related issues), so this should be released first.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ❌ Developer Documentation support
- ➖ User Guide Documentation support
- ❌ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Added
logo-email.png, a PNG logo for HTML emails.
AI-Generated: Yes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 01-logo-compare-img-src.png | 51.9 KB | rajab natshah |
| #5 | 01-logo-after-html-check.png | 94.35 KB | rajab natshah |
| #5 | 01-logo-after-email.png | 36.52 KB | rajab natshah |
| #5 | 01-logo-before-html-check.png | 158 KB | rajab natshah |
| #5 | 01-logo-before-email.png | 36.37 KB | rajab natshah |
Issue fork vartheme_bs5-3637288
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rajab natshahComment #4
rajab natshahMR !257 is ready for review. Varbase Starter points at the new file in #3637289, so this one goes first.
Comment #5
rajab natshahBefore and after evidence for !257, tested on Varbase 11.0.x with Varbase Starter (Drupal 11.4.12, local DDEV + Mailpit).
Before: the password reset email on Varbase 11.0.x with Varbase Starter 1.0.x-dev. The header logo is the theme's logo.svg.
Before: Mailpit's HTML Check lists 20 warnings, including SVG image format. A linked SVG image is not supported in about 24% of tested email clients (Apple Mail, Outlook for Windows, several Gmail versions) and partly supported in about 12% more.
After: the same email with the new logo-email.png (150 x 30 PNG). It renders the same, and more email clients can show it.
After: HTML Check lists 19 warnings. The SVG image format warning is gone; the remaining rows are the same as before.
The logo img src in the sent HTML: themes/contrib/vartheme_bs5/logo.svg before, themes/contrib/vartheme_bs5/logo-email.png after (set by Varbase Starter's easy_email_theme.settings.yml). Cropped from Mailpit's HTML Source tab.
Release order: vartheme_bs5 !257 first (it adds logo-email.png), then Varbase Starter !90 in #3637289, which points at it.
AI-Generated: Yes
Comment #6
rajab natshahComment #8
rajab natshah✅ Released in vartheme_bs5 5.0.10