Reviewed & tested by the community
Project:
Drupal core
Version:
main
Component:
extension system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Nov 2026 at 03:58 UTC
Updated:
14 Nov 2026 at 18:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
nicxvan commentedComment #5
nicxvan commentedRebuilt this after the recent issues. This is ready for review again.
Comment #6
dcam commentedI did my best to validate all of the types of the new annotations. I had trouble figuring out where the
$requiredproperty is set or used. But since it's typed as an array like$required_byand$requires, I'm guessing it's OK.There is one remaining baselined
property.notFounderror for\Drupal\Core\Extension\Extension.ExtensionSerializationTest::testPublicProperties()sets the property$test. It's done solely for the purpose of testing serialization of extension properties. So this one seems like one we don't want to add an annotation for. Might we want to add a@phpstan-ignorein order to get it out of the baseline?Comment #7
nicxvan commentedThank you @dcam for your in-depth review!
I could have sworn I saw required, I pulled it from the issue linked in the IS let's remove it and see if phpstan complains.
Also for the test property, instead of ignoring it I just changed the property to a known property.
Comment #8
dcam commentedSounds good to me. Thank you for checking my feedback.
Comment #9
catchI can understand doing a stopgap here, but I feel like I need to ask - could we not make these public, readonly properties and leave it like that?
Comment #10
nicxvan commentedMoved the theme specific ones to the Theme value object.
This should be ready for review again, I'll keep an eye on tests.
Comment #11
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #13
quietone commentedDoes anyone know if @property is handled correctly by the API project? Or by Doctum, which is there is an issue to switch to?
Comment #14
mstrelan commented@quietone there is an example in FieldItemListInterface, it just shows up as plain text.
It has better support in doctum, see MessageSent in laravel, where
$messagecomes from a@propertyannotation.Comment #15
quietone commented@mstrelan, thanks. I did some more searching and yes, it is displayed as just a string but without a line break. So, no a.d.o doesn't handle @property.
Comment #16
nicxvan commentedWe should probably create an issue in the api project to track this. I don't think it should block this issue though.
Comment #17
nicxvan commentedComment #18
phenaproximaI reviewed this and I think it's good to go. Tagging for a follow-up per #16.
That said: this is only changing comments, which are easy to adjust later if needed...and the changes here lop 700 lines out of the PHPStan baseline. I think that's a win.