Problem/Motivation

From #3532930-48: Make Drupal\Core\Database\Database type strict and PHPStan L10 compliant:

Looks like the assert(isset($connection_info['autoload'])); added to Database::parseConnectionInfo() in this issue has broken 11.x and 11.5x mysqli tests in migrate_drupal/migrate:
https://git.drupalcode.org/project/drupal/-/jobs/12883913
https://git.drupalcode.org/project/drupal/-/jobs/12883914
https://git.drupalcode.org/project/drupal/-/jobs/12883915
https://git.drupalcode.org/project/drupal/-/jobs/12883916

Example:

Upgrade7With Content Moderation (Drupal\Tests\migrate_drupal_ui\Functional\d7\Upgrade7WithContentModeration)
     ✘ Upgrade and incremental
       ┐
       ├ AssertionError: assert(isset($connection_info['autoload']))
       │
       │ /builds/project/drupal/core/lib/Drupal/Core/Database/Database.php:307
       │ /builds/project/drupal/core/lib/Drupal/Core/Database/Database.php:350
       │ /builds/project/drupal/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php:192
       │ /builds/project/drupal/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php:158
       │ /builds/project/drupal/core/modules/migrate/src/Plugin/migrate/source/SqlBase.php:216
       │ /builds/project/drupal/core/modules/migrate_drupal/src/Plugin/migrate/source/DrupalSqlBase.php:111
       │ /builds/project/drupal/core/modules/node/src/Plugin/migrate/D7NodeDeriver.php:81
       │ /builds/project/drupal/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php:101
       │ /builds/project/drupal/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php:87
       │ /builds/project/drupal/core/modules/migrate/src/Plugin/MigrationPluginManager.php:259
       │ /builds/project/drupal/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php:216
       │ /builds/project/drupal/core/modules/migrate/src/Plugin/MigrationPluginManager.php:138
       │ /builds/project/drupal/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php:265
       │ /builds/project/drupal/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeExecuteTestBase.php:88
       │ /builds/project/drupal/core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php:236
       ┴
    
    FAILURES!
    Tests: 1, Assertions: 16, Failures: 1.

main and 12.0.x do not seem to be affected because those migrate tests have been removed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3631193

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

godotislate created an issue. See original summary.

godotislate opened merge request !17469

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review
Parent issue: #3532930: Make Drupal\Core\Database\Database type strict and PHPStan L10 compliant » #3294695: Drupal 8 BC for database driver namespace fails for replicas

MR: https://git.drupalcode.org/project/drupal/-/merge_requests/17469/

mysqi job passes: https://git.drupalcode.org/project/drupal/-/pipelines/1005313

Maybe we don't need to worry about the test failures since they're in tests removed from core, and the failure is in a BC layer, but the fix is pretty trivial: https://git.drupalcode.org/project/drupal/-/merge_requests/17469

Maybe it makes sense to forward port the changes for consistency, not sure.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3533038: Introduce a ConnectionParameters value object to store database connection parameters

tbh, on main I’d rather go for #3533038: Introduce a ConnectionParameters value object to store database connection parameters.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 61f57dd2015 to 11.x and 12caff74819 to 11.5.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 12caff74 on 11.5.x 
    fix: #3631193 [11.x] Test failures in mysqli jobs because connection...

  • longwave committed 61f57dd2 on 11.x 
    fix: #3631193 [11.x] Test failures in mysqli jobs because connection...