Needs review
Project:
Drupal core
Version:
main
Component:
database system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2025 at 17:01 UTC
Updated:
28 Sep 2026 at 14:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
moshe weitzman commentedLGTM
Comment #4
mondrakePostponed on #3532930: Make Drupal\Core\Database\Database type strict and PHPStan L10 compliant
Comment #5
mondrakeComment #6
mondrakeThe MR is built on top of #3532930: Make Drupal\Core\Database\Database type strict and PHPStan L10 compliant, but it is reviewable now.
Comment #7
smustgrave commentedThis is looking good from what I can tell. Postponing and jumping to the blocker.
Comment #9
mondrakeComment #12
mondrakeComment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
mondrakeComment #15
mondrakeWorking on tuning array access and cloning
Comment #16
mondrakeUsed PHP 8.5
clone withsyntax, guarded the value objects from casual array access writes.