Problem/Motivation

When you load the settings page it will list entity types that shouldn't be supported, e.g. Feeds, Domain Access, etc. This also affects the entity type selector on the "Add defaults" page.

Steps to reproduce

Go to: admin/config/search/metatag/settings

Only reasonable entity types will be listed.

Proposed resolution

Improve the logic in getSupportedEntityTypes().

Remaining tasks

Improve the logic in getSupportedEntityTypes().
Improve test coverage.

User interface changes

The settings page won't list entity types where it doesn't make sense to support them.

API changes

TBD

Data model changes

n/a

Issue fork metatag-3631155

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3548158: Plan for Metatag 2.2.1
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

The MR excludes entity types as follows:

  • Content entities.
  • Not an "internal" entity type (not sure when this might be relevant?).
  • The rendered output is catchable; this excludes Paragraphs Library Items.
  • There is a canonical URL defined.
  • The canonical URL is not the same as the edit URL.

damienmckenna opened merge request !278

  • damienmckenna committed 98c04712 on 2.2.x 
    Issue #3631155 by DamienMcKenna: Improved limiting of entity types.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Needs review » Fixed

Committed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.