Problem/Motivation

I think it would be nice to 2 additional options in entity_usage_plus:
- One to toggle the 'show usage in old revision' filter on the usage tab/page
- One to set the default value for the filter on the usage tab/page

CommentFileSizeAuthor
#5 3630419.patch11.83 KBshank115

Issue fork entity_usage_plus-3630419

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jasongose created an issue. See original summary.

jastraat’s picture

jastraat commented
Title: More options » Incorporate new functionality of entity_usage plus (e.g. hiding old revisions)
jastraat’s picture

jastraat commented
Title: Incorporate new functionality of entity_usage plus (e.g. hiding old revisions) » Incorporate new functionality of entity_usage 5.x (e.g. hiding old revisions)
shank115’s picture

shank115 commented
Status: Active » Needs review

Attached a patch that adds the entity_usage 5.x "Show usage in old revisions" filter to the Entity Usage Plus usage tab, plus the two options requested in the summary.

shank115’s picture

shank115 commented
StatusFileSize
new 3630419.patch11.83 KB
jastraat’s picture

jastraat commented

@shank115 - first off, I just want to say how much I appreciate you taking a stab at this.

I spoke with one of the other maintainers today and the description of this issue could have been more clear.

There are two issues related to the old revisions filter added by entity_usage.

  • If someone is using the overridden controller from entity_usage_plus, it does not currently expose the option that is available from entity_usage to, via a checkbox on the tab display, hide old revisions.
  • The approach entity_usage uses to hide old revisions is not compatible with Claro.

The first issue is what I was hoping to solve in this PR. So that installing entity_usage_plus wouldn’t be a downgrade of functionality for folks using the overridden controller. You actually solved that in this PR without the need for config options!

Separately, we'd like to add a config option to optionally hide that filter option on the tab since it's currently not compatible with Claro.

However as it happens... it looks like you've also been working that bug from the other angle in https://git.drupalcode.org/project/entity_usage/-/work_items/3629517 (so thank you again)

Could we remove the new config options from this PR and just keep the awesome fix that allows the entity_usage filter to be applied? Alternatively, have a single config option that disables the old revision filtering on the tab for folks who are sadly using Drupal 11 and aren't compatible with HTMX yet.