Needs review
Project:
Drupal core
Version:
main
Component:
phpunit
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Oct 2026 at 07:53 UTC
Updated:
28 Oct 2026 at 18:03 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
leandro713 commentedliking to work on this
Comment #4
leandro713 commentedThe merge request replaces the state service with direct access to its
underlying key/value collection in the container rebuild test module and its
functional test.
The now-unnecessary state cache refreshes have also been removed.
Local checks:
- PHP syntax checks passed.
- PHPCS passed.
- The functional test was not run locally because a functional test environment
is not configured. It is being exercised by CI.
AI-Generated: Yes. I used ChatGPT to help analyse and draft the initial change.
I reviewed the resulting diff and ran the reported checks locally.
Comment #5
catchThis should use a custom collection name rather than 'state'.
Comment #6
leandro713 commentedThanks! The merge request now uses the dedicated
`container_rebuild_test` key/value collection, with `count` as the key.
`RebuildScriptTest` has been updated accordingly.
Comment #7
leandro713 commentedComment #8
smustgrave commentedPosting this as this may violate our AI policy
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...
Comment #9
leandro713 commentedThanks for pointing me to the policy. I have read it and would like to clarify how I used AI for this contribution.
I used ChatGPT to suggest an initial implementation and help draft the merge request text. I independently reviewed and understood every code change, ran the reported local checks, incorporated catch's feedback, and verified the updated result. I take full responsibility for the submitted work.
English is not my first language, and Drupal core issues can involve complex technical discussions. Before investing effort in a contribution, I use AI as a supporting tool to check that I have understood the problem correctly and to express my reasoning clearly in English. It does not replace my own technical judgement or responsibility; it helps me avoid misunderstandings caused by language.
If there is a specific part of the contribution or disclosure that does not meet the policy, please let me know and I will correct it.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
leandro713 commentedThe MR has been rebased onto the latest `main` branch, and the merge conflicts have been resolved.
Both original changes have been preserved, including the dedicated key-value collection for tracking container rebuilds.
I also updated `KernelTestSharedContainerTest` to use the new collection, fixing the three failing Kernel tests identified by CI.
The latest pipeline has completed with warnings only, related to PHP deprecations outside the scope of this issue. No failing jobs remain.
The issue is ready for review again. Thanks!
Comment #12
abryantdev commentedTested MR !17380 (commit 1def14270ec) locally on Drupal main, PHP 8.5, SQLite.
KernelTestSharedContainerTest passes (3 tests, 3 assertions).
RebuildScriptTest passes (1 test, 22 assertions).
I also searched core for other readers of the old 'container_rebuild_test.count' state key and found none. The module name still appears in the $modules lists of ContainerResetWebTest and RebuildScriptTest, which is expected.
The MR uses a dedicated 'container_rebuild_test' key/value collection with 'count' as the key, which matches catch's feedback in #5. I did not change the issue status.
AI use: an AI assistant set up and ran these tests and drafted this comment. I reviewed the results before posting.