Problem/Motivation

The README, help page and form don't explain some behavior that
surprises admins:

  • Users whose passwords are reset are logged out of all sessions
    (core deletes a user's sessions when their password changes). This
    includes uid 1 when "Include admin user" is checked.
  • "Include admin user" has no effect when uid 1 runs the reset, because
    the user running the reset is never included. To reset uid 1, run it
    from another admin account.
  • Emails are only sent when "Notify active users" or "Notify blocked
    users" is checked.

Also in the same text:

  • Typo "authenicated" in README.txt and the help page (flagged by
    cspell).
  • The help page link to the form is hard-coded to
    /admin/people/mass-pwreset, which breaks on sites installed in a
    subdirectory.
  • The "Password Reset Options" list on the help page is not
    translatable.

Proposed resolution

  • Update README.txt, the help page and the form descriptions to
    cover the three behaviors above.
  • Fix the typo.
  • Build the help page link with Url::fromRoute().
  • Wrap the help list items in t().

Remaining tasks

  • Create MR
  • Review

User interface changes

New/updated descriptions on the Mass Password Reset form and help
page.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mikebarkas created an issue. See original summary.

mikebarkas’s picture

Status: Active » Reviewed & tested by the community

mikebarkas changed the visibility of the branch 3628946-document-session-logout to hidden.

  • mikebarkas committed 585a8425 on 2.x
    Issue #3628946 by mikebarkas: Document session logout, "include admin"...
mikebarkas’s picture

Assigned: mikebarkas » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.