Problem/Motivation

The project has no GitLab CI configuration, so merge requests do not receive automated checks.

Steps to reproduce

Create a merge request. No pipeline starts.

Proposed resolution

Add the standard Drupal GitLab CI configuration. Update the existing functional test to use the stark theme instead of stable, so it runs on Drupal 11.

Equivalent GLightbox Media Video issue: #3628628.

Remaining tasks

Review and merge the MR.

Issue fork glightbox-3628635

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nick hope created an issue. See original summary.

nick hope opened merge request !16

nick hope’s picture

nick hope commented
Assigned: nick hope » Unassigned
Issue summary: View changes
Status: Needs work » Needs review

levmyshkin made their first commit to this issue’s fork.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Closed (won't fix)

It failed for me on gitlab with error:
ERROR: Uploading artifacts as "archive" to coordinator... 413 Request Entity Too Large correlation_id=2093685279 id=12677047 status=413 token=69_5iDF5x
FATAL: too large
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: command terminated with exit code 1

https://git.drupalcode.org/project/glightbox/-/jobs/12677047

I'm not sure if we need to add gitlab CI without all needed tests.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.