Admin Toolbar is broken with drupal 11.3.18

I tried to reproduce this on a site with:

• Drupal 11.3.18
• Admin Toolbar 3.6.3, with Admin Toolbar Extra Tools and Admin Toolbar Search enabled
• Claro as the admin theme

From the screenshot, the toolbar's CSS/JS doesn't seem to be loading, so this could be a caching or asset aggregation issue, especially right after a core update.

Could you please share any errors in the browser console, and any failed (404) CSS/JS requests in the Network tab?

Could there be any conflicts with any of the installed modules?

Such as Workbench?

The screenshot from #5:

Looks very much like there is something broken in the HTML of the Toolbar.... A missing closing HTML Tag, such as </div> or </ul>, etc....

Any chance you could try to do some debugging on this toolbar?
Disable/enable certain menu items, modules, etc.... Just to try narrowing down the source of the issue....

Did you try enabling / disabling certain modules for testing Shashank (@shashank5563)?
(As suggested above at #6)

Your patch is huge and seems to modify Core files as well ⚠️ ... It does not seem right, does it?
I don't think this patch is useable.

I think the context and details on the problem are still not very clear at this point.
Any chance you could provide more information on the actual issue and the steps to reproduce it ?

Thanks in advance!

At the very least ... try disabling admin_toolbar_tools, admin_toolbar_search, then admin_toolbar and see if the problem is the same or not....

In which case it would rather be related with the Drupal Core Toolbar module and with Admin Toolbar.

In any case, you would need to try narrowing down a bit the cause of the problem....

I cannot reproduce this when following the stated "Steps to reproduce" in the issue summary. I tested on a fresh Drupal site with:

• Drupal 11.3.18 core
• Admin Toolbar 3.6.3
• Both with and without Admin Toolbar Extra Tools and Admin Toolbar Search enabled
• Claro as the admin theme
• Olivero as the default theme

Admin Toolbar works fine in this context.

The "Steps to reproduce" does not mention Workbench, but Workbench is visible in the screenshots. So I added the following:

• Workbench 8.x-1.6
• Workbench Access 2.0.5
• Workbench Email 3.0.8
• Workbench moderation
• Workbench Moderation 8.x-1.9
• Workbench Moderation Actions 2.1.0-alpha2

There are a number of other Workbench modules, but it's not clear which ones are installed on the site in the screenshots from @shashank5563.

With the above Workbench modules added, I still could not reproduce the issue and Admin Toolbar works fine. Screenshot attached.

I agree with @dydave that additional information and testing is needed from @shashank5563.

Super nice Cam (@camhoward)! 🤩
Thanks a lot! 🙏

You're definitely getting credited on this issue for the great review and testing feedback. 👌

Requalified issue as Support request, for now, to prevent "wrongly" inflating module's open bugs stats.

Thanks again!

@dydave - Thanks for the offer of credit for helping with testing. I wasn't expecting that, but it's very thoughtful!

@shashank5563 - I tested again on a fresh Drupal 11.4.8 site, the version you used in your test and screenshots in comment #13. I also tested on Drupal 11.4.10 after the security update.

I still can't reproduce the issue.

Based on your screenshots, it seems to be a CSS issue that is affecting both Admin Toolbar and Navigation. This may mean the issue is not specific to Admin Toolbar.

It's not clear to me what is different about our two fresh Drupal installations that would result in us seeing different results.

I tested using:

• Environments: DDEV and DrupalForge
• Drupal core profile: Standard Drupal install
• Language: English
• Admin Toolbar: 3.6.3
• Submodules: Tested with and without Admin Toolbar Extra Tools and Admin Toolbar Search

Attached are screenshots from my tests in 11.4.8.

Can you provide more information about your installation? Or can you test using DrupalForge so we know we are both using the same environment?