Problem/Motivation
This theme was cloned from Vartheme BS5 (the Varbase Starter theme) and its Storybook still carries the base theme's branding and sample content. The Rightup is a media / news / magazine site template, so its component library should read editorially, not as Varbase product marketing.
Verified against 1.0.x at commit 566661c:
components/foundation/colors/colors.stories.twig:6— the story description readsGetting started page for Varbase Storybook.components/getting-started/about/about.stories.twig— the story machine names areGettingStartedAboutVarbaseandAboutVarbase; the body describes "Varbase theming conventions" and links todocs.varbase.vardot.comfour times.- Sample copy across several components is Varbase product marketing rather than editorial content:
Varbase; Better Than Ever—heroslider.stories.twig,hero-slider-container.stories.twigElevate your digital experience with Varbase's dynamic design system—card-hero.stories.twig(twice)Build faster with Varbase—hero-slide.mdx- two Varbase strings in
media-banner.stories.twig
Scope: 8 of 85 *.stories.twig, 6 of 85 *.stories.json (generated from those Twig sources), 1 of 76 *.mdx.
Steps to reproduce
- Run Storybook against this theme.
- Open
Foundation/Colors,Getting Started/About,Hero/Heroslider,Cards/Card HeroandOrganisms/Media Banner. - Read the copy.
Proposed resolution
Replace the viewer-facing Varbase content with Rightup-appropriate editorial sample content (headlines, bylines, article teasers, publication-style imagery), and correct the About page so it describes The Rightup rather than Varbase.
Only viewer-facing copy changes. A blanket find-and-replace on "varbase" would break the theme: varbase-video-player is a real CSS class in the Carousel story's sample markup, varbase_components is a real module, varbase_heroslider is a real content type, and vartheme_bs5_rightup: is the SDC namespace. This is the same class of mistake as the theme's own name Vartheme BS5 Rightup in #3627146, which was correct and had to be left untouched.
The design file does contain component designs. The page listing returned by the Figma API is incomplete — it reports only "Cover" and "• Foundation" — but querying page nodes directly reveals at least:
- Blocks — text-block (6 variants: background none/dark/light × alignment left/center), media-block (1:1, 4:3 and 16:9 ratios, plus a 6-column fitted variant), accordion-block (vertical and horizontal layouts), tabs block, featured-block, what-youll-get, related-articles-horizontal, related-episodes-horizontal, latest-articles-view (light and dark), latest-content-type/vertical, podcast-block, episodes-view (desktop and mobile), latest-podcasts-view, mobile-latest-podcasts-view, and subscribe-block (large and small).
- • Icons — social icons (Facebook, Twitter, Instagram, LinkedIn, Share across light/dark and default/hover), podcast stream icons (Spotify, Apple Podcasts, Google Podcasts, Overcast, RSS), slider play/pause/arrow/pager icons in light and dark, chevrons, common icons at several sizes, checkbox, radio, toggle, close-button, link icons, list icons, flags, sort icons and numbers.
- • Spacing & Grids — screen widths 1320 / 1140 / 960 / 335, twelve-column grids for desktop, tablet and mobile, and col-2 through col-12.
- • Images — hero, banner and teaser image specifications, responsive images, image alignment, and 16:9, 1:1 and search image sets.
- Components — a page of this name exists, though it returned empty through the API.
So a genuine comparison between the design and the theme’s 85 components is possible and should be part of this work. The scope therefore includes mapping the design’s blocks and icons onto the existing Storybook components, identifying which design pieces have no component and which components have no design counterpart.
Remaining tasks
- ✅ File an issue
- ❌ Map the design’s Blocks and Icons pages against the theme’s 85 components and record the gaps in both directions.
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ❌ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- Storybook sample copy and the Getting Started/About page. No change to what the theme renders on a site.
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Storybook sample content now reads as The Rightup rather than Varbase.
Issue fork vartheme_bs5_rightup-3627179
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rajab natshahComment #4
rajab natshahComment #6
rajab natshah