Problem/Motivation

Two Storybook problems, both left over from the clone of Vartheme BS5. Verified on 1.0.x at commit d7c0587.

1. The Vardot logo is missing from the Welcome page. The base theme's Welcome story has two columns in its top row: the product logo on the left, and vardot-logo.svg at 75px wide on the right. Rightup kept only the first. The asset is still shipped at components/foundation/images/assets/vardot-logo.svg, and nothing in Storybook references it.

2. The product name is written three ways. The site template is called The Rightup. The theme writes it as "Right Up" in 28 places and as camel "RightUp" in 7 more.

  • "Right Up": logo-icon.svg and components/foundation/images/assets/favicon.svg (aria-label); components/foundation/logos/logos.stories.twig (11 alt and title strings); components/getting-started/about/about.stories.twig and its .json (story title "Getting Started/About Right Up", story name "About Right Up", 2 body strings); components/getting-started/welcome/welcome.stories.twig and its .json; components/organisms/navbar/navbar.stories.twig and its .json (alt "The Right Up logo", twice).
  • Camel "RightUp": the CI badge label in README.md, and comments in scss/base/vartheme.base.scss, scss/theme/newsletter-subscribe.theme.scss, tests/README.md and cucumber.js.

Not in scope: "Vartheme BS5 Rightup" is the theme's own name (236 occurrences, in composer.json, the info.yml, the libraries and icons yml files, README.md and starterkit.md) and it is correct. Only the site-template product name is being corrected here.

Steps to reproduce

  1. Build Storybook for the theme and open it.
  2. Getting Started, Welcome: only the product logo, no Vardot logo on the right of that row.
  3. Getting Started "About Right Up", Foundation "Logos", Organisms "Navbar": the product is named "Right Up".

Proposed resolution

  1. Restore the Vardot logo column in the Welcome story, matching the base theme exactly: vardot-logo.svg, 75px wide, alt "Vardot Logo", in a right-aligned column of the same row.
  2. Write the product name as "The Rightup" in every string listed above, including the camel-case comments, and set the README badge label to "Vartheme BS5 Rightup".
  3. Edit each *.stories.twig and its generated *.stories.json by hand, keeping the pair in sync. Do not run ddev storybook gen: it rewrites option keys unquoted, the @storybook/preset-server-webpack JSON-to-JS loader cannot parse them, and the preview build fails with "Module parse failed: Unexpected token". Reproduced while investigating this. The committed files carry those keys hand-quoted.

Before and after

Storybook Welcome page, captured at 1440x900 through the Storybook root URL on a local DDEV build of this theme.

Before: no Vardot logo in the top right, and the product is named "The Right Up".

 nothing in the top right of the heading row, the heading reads Welcome To The Right Up's Design System

After: the Vardot wordmark sits in the top right, matching the base theme Vartheme BS5, and the product is named "The Rightup".

 the Vardot wordmark in the top right, the heading reads Welcome To The Rightup's Design System, the sidebar entry reads About The Rightup

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • The Storybook Welcome page carries the Vardot logo again.
  • The Storybook pages name the product "The Rightup".

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Storybook pages show the Vardot logo again and name the product "The Rightup".
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Status: Active » Needs review

  • rajab natshah committed 566661c4 on 1.0.x
    fix: #3627146 Restore the Vardot logo and write the product name as The...
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.