Our Weekly pipeline is failing again, with several different problems reported.

#3616723: Fix phpstan findings in recent pipelines should already cover some of this (namely, the PHPStan errors).

Part of the problems in “next minor” are caused by #3427095: [Meta] Deprecate text_with_summary, since a lot of our tests use that field type for their body field. Just changing that to text_long mostly works, but RenderedItemTest also relies on a summary being present, so more work is needed here. (There is a contrib module filling the gap, but for obvious reasons it is not compatible with Drupal versions 11.4 and lower, so just requiring that also doesn’t work.)

Issue fork search_api-3624636

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

the text_with_summary field is still in core for next minor, but you might need to enable the extra module although you should just get deprecation errors, I think? it's in next major where it is removed.

It should also be possible to add it to composer require dev, core should now include the replace statement for previous versions. I *think*?

most fails on current minor are because of what I think was a mistake, we ship the body field in the testing profile but with a different type. so you get conflict conflicts if you expect it to be text_with_summary. The only sensible workaround is to rename your field to something else but body in your test config/modules and ship with a field storage as well.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

And the filter repository errors should be resolvable by explicitly requiring the filter module to be enabled in the affected kernel tests

drunken monkey opened merge request !366

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review

Thanks for your helpful comments, that at least saved me some time hunting for explanations. Still, pretty horrible DX by Core with these changes …

It should also be possible to add it to composer require dev, core should now include the replace statement for previous versions. I *think*?

I fear not, tried it but didn’t work. I’m now requiring it conditionally as an after_script, that seems to work.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

OK, everything else was bad enough, but I really struggle to see any benign explanation for the “next minor” (= Drupal 11.5) version identifying as 11.4-dev. Jesus Christ …

  • drunken monkey committed 576598ff on 8.x-1.x 
    ci: #3624636 Fixed failing pipelines.

By: drunken monkey
By: berdir
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Finally!

Note: This also declares compatibility with Drupal 12, even though it cannot be tested at this point since none of the dev requirements are ready. I created #3630149: Enable testing for Drupal 12 as a follow-up.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.