Problem/Motivation

The footnotes 4.x does not have a stable release so is not security covered yet. Get fable/mythos to review.

Fable has identified some edge cases:

  1. The parent text format inherits the allowed options from the footnote format. E.g. if parent doesn't have <a> it then makes that available. Low risk given the footnote format has very little options, but worth putting a warning when the icon is added to the toolbar
  2. When grouping footnotes together, cache is per URL. Its possible that someone uses footnotes e.g. within a members area where different e.g. blocks are shown per user. Footnote content would then not be unique to users. Warn about this as well when enabling group by
  3. Preview character is plain text, it should be escaped. The site admin would have to malicious to do something malicious there, but let's escape it.
  4. The search api ignore citations processor classname search should search on a css-friendly classname only
  5. Tweak to loading dialog html to use cloning instead to avoid any html mutation

Proposed resolution

Add warnings + hardenings

Remaining tasks

MR

User interface changes

Warnings show up as noted above

API changes

N/A

Data model changes

N/A

Issue fork footnotes-3623909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

scott_euser created an issue. See original summary.

  • scott_euser committed d30a26d9 on 4.0.x
    fix: #3623909 Add warnings re text format and grouping, add further edge...
scott_euser’s picture

Assigned: scott_euser » Unassigned
Status: Active » Fixed

Test coverage added + manually tested and validated warnings show up, preview character still works, dialog still works.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.