Problem/Motivation

Scanning the module with phpstan or Upgrade Status results in,

Storing entity storage as a class property is not recommended. Call Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the call-site instead.

Proposed resolution

Call getStorage() instead.

API changes

Theoretically, a third-party class that extended the offending class could have to change its structure as well.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

benstallings created an issue. See original summary.

benstallings’s picture

Assigned: benstallings » Unassigned
Status: Active » Needs review