[meeting] CLI in Core Initiative Meeting 2026.09.09 [#3623588]

Hello, everyone. Welcome to the ✨ CLI in Core Initiative ✨ Meeting! 📅 This meeting:
➤ Usually happens weekly either at Wednesday 14:00 UTC.
➤ Will use Slack threads to continue discussions.
➤ Please comment on the roll call thread throughout the day.

0️⃣ Roll Call! Who is here today? Introduce yourself including your name and drupal.org username.

mradcliffe	Matthew here (mradcliffe)
amateescu	Andrei here (amateescu)

1️⃣ RTBC status of #3594336: Add a command to list modules and themes on a site

mradcliffe	A couple of things I noticed from reviewing last night:I think the format options help could be a bit more verbose and a full sentence. I found the code to be understandable. The $both variable name seemed to be a bit generic, but I don't think it's an issue.
moshe	Go for it. Symfony decided that their new Enum approach which we are using here affects validation of the option value, and for shell autocomplete, but is not used for the help. I think you can hard code supported format names into the help. (edited)

2️⃣ Stalled status of #3594320: Allow `dr install` to install when database is already configured

mradcliffe	Have anyone had any time to review my comments about changing the approach to this? CC: @balsama
mradcliffe	I think database driver specific methods in generic classes have been discouraged. What do you think, @amateescu?
amateescu	they are discouraged, and the current way to do it "properly" is to have a generic method in the base class and implement db driver specific service overrides
amateescu	like this: #2306083: Backend specific services now have a standard way to override
mradcliffe	In this case because install is currently locked to sqlite , to be backwards-compatible it still needs to support that by default without requiring pdo_sqlite because, and I think mainly, core tests use install rather than quick-start.
mradcliffe	I played around with it a bit, and I think I can change it, but I wanted to get feedback first before changing the approach in the merge request.
amateescu	maybe this issue should be blocked on #3594342: Update install command to allow installing using any database driver though?
amateescu	keeping dr install sqlite-only is not really useful for anyone most people 🙂 (edited)
mradcliffe	I felt like that one is a much larger issue, and originally thought we could get this one in before Rotterdam.
amateescu	I'd have to look more closely at what's holding up #3594320: Allow `dr install` to install when database is already configured to give a more informed answer...
mradcliffe	Also at the moment with the approach, the install command still passes sqlite configuration to the install tasks, but that is ignored because of an existing settings.php, which is odd.
mradcliffe	another problem affecting both is the database checks can't be run because the kernel tries to boot first, which will explode anyway if it can't make a database connection.
amateescu	🫣
mradcliffe	kill all includes ☺️
amateescu	I'm reviewing #3391683: Convert initial functions in update.inc file to a class right now 🙂
mradcliffe	Oh, no, I found a `\Drupal::service('update.update_hook_registry')->setInstalledVersion($module, $number);` 😠 (edited)
amateescu	yeah, I have a code suggestion for that in the review
mradcliffe	I fixed it.
mradcliffe	I think I need to stop trying to keep all the commits in a merge request once it gets over 10 commits and squash them down during a rebase.
amateescu	review posted 🙂
mradcliffe	Thank you.
mradcliffe	A question about the constructor arguments change. Since we're doing it in 2 issues, we would need a change record to add those 2 arguments back in the follow-up issue(s).
amateescu	oh.. wasn't aware of that 🤔 then feel free to ignore that suggestion
mradcliffe	I know I removed one already on a previous review. Although I think not including them now is appropriate.
mradcliffe	Maybe the follow-up issue comes in 12.1.0
amateescu	then apply it 😂
mradcliffe	Will do. I am going to set back to NR, and vigorously review the code from the most recent rebase to make sure I didn't miss anything else.
amateescu	I already set it back to NR 😉
amateescu	(with a free self-rtbc card)

3️⃣ Database update related issues #3594333: Add a database update command

mradcliffe	#3391683: Convert initial functions in update.inc file to a class, I think getting that and its follow-up issue in will really help make the database update commands cleaner to implement.
moshe	#2999721: [META] Deprecate the legacy include files before Drupal 9 got in 🙌 (edited)

4️⃣ Rotterdam 2026 Scheduling/Planning

mradcliffe	Did you want to plan a time during the week to meet in general contrib or BoF space to follow-up on @moshe session, @kimb0?
kimb0	I'm still working out my schedule. Perhaps closer to the date?

Participants:

mradcliffe, amateescu, moshe, kim.pepper