Refactor the field parsing from the EXIF DropzoneJS to reuse the functionality from the functionality added in #3621899: Parse all uploaded media (Add EXIF parsing to Simple Media Bulk Upload).

Issue fork exif-3622789

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Refactor field mapping » Rewrite EXIF DropzoneJS logic to use EXIF field mapping
Status: Active » Needs review

damienmckenna opened merge request !32

nitinkumar_7’s picture

nitinkumar_7 commented

I was looking at the config changes and the updated test. The new exif.field_map setup looks good, and I see that the old DropzoneJS test has been moved into TestMediaImageUploader.

nitinkumar_7’s picture

nitinkumar_7 commented

One thing im not sure about though: what happens to sites that already have exif_dropzonejs.field_map configured? Do we need an update hook to move those existing mappings to the new exif.field_map setting, or is there already something handling that?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

That's fair, I'll add an update script.

damienmckenna opened merge request !33

  • damienmckenna committed 0c595839 on 8.x-2.x 
    Issue #3622789 by DamienMcKenna, nitinkumar_7: Update script to update...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Needs work » Fixed

Committed. Thank you for the feedback, nitinkumar_7.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.