Problem
The port carries code nothing calls and configuration nothing references:
l10n_community_project_create()implements a hook for an entity type namedproject. The type isl10n_server_project, so it never ran, and it would have created path aliases before the project had an id.L10nCommunityProjectsController::overview(),releases()andtitle()are stubs printing their method name. No route uses them, andtitle()was the only user of the injected route match.L10nStatistics::getTotalStringCount()andgetProjectStringStatsByLanguage()have no callers.- Connector API without callers:
ConnectorInterface::getDescription(),SourceInterface::getDescription(),ConnectorManager::getOptionsList()andsetConnectorPluginStatus(),L10nPackager::API_VERSION, and the file system and HTTP client injected into the drupal.org connector and never used. - The base module routes
/admin/config/l10n-server/packagerto the packager settings form, which fatals when l10n_packager is not installed and is shadowed by the packager's own route otherwise. - The base module alters the Views data of translations with a relationship to the translation groups, a Group module concept the base module knows nothing about.
l10n_community.group.permissions.ymlrepeats four of the eight group permissions of l10n_groups.views.view.l10n_server_projectsis installed with the base module but referenced nowhere, the project list is the list builder.- Three of the five toolbar icon colour sets are not referenced by the toolbar stylesheet.
- The user profile block declares its cache context under the wrong key, so the block was not varied by path.
Proposed resolution
Remove all of it. The Views relationship moves to l10n_groups. The group permission descriptions move to the l10n_groups file, whose browse permission takes its Drupal 7 name. The profile block cache key is corrected.
Left in place on purpose, they are in use on localize.drupal.org: the l10n_theme module (site configuration enables it, its stylesheet belongs in the site theme), the user profile block and the "Teams User Block" display of the memberships view (both placed in the site configuration), and the table striping script attached on every page. The upload source still inherits the cron scanning settings of the configurable sources, a separate question.
Tests
Nothing to add, nothing removed was covered or reachable. The whole suite passes after the removal.
LLM disclosure
LLM was used to find, diagnose explain and fix this issue. With human review.
Comments
Comment #3
gábor hojtsy