Problem

Four things the Drupal 7 packager tools do that the port does not:

  • "Repackage now" on a release that was never packaged does nothing: the batch returns when the release has no packager record yet, where Drupal 7 creates the record on the first check.
  • "Mark for repackaging" prints the SQL of its query as an error message, a debugging leftover.
  • Saving the packager settings never creates the packages directory: the directory check runs without the create flag. Drupal 7 creates it from the form.
  • The downloads tables show the creation date of the file record, which stays at the first packaging; Drupal 7 shows the date of the last packaging.

Proposed resolution

  • The repackage batch creates the packager record of a release packaged for the first time.
  • The debugging message goes.
  • The settings form creates the directory while validating and refuses a directory it cannot create.
  • The downloads tables show the change date of the file, set on every packaging.

Tests

Drupal 7 first: testAdminTools() in the packager test repackages a release never packaged before through the tools page, marks it for repackaging, repackages it again with the file dates set back and checks they are refreshed, and saves a new directory on the settings page. Ported as PackagerAdminTest, which also checks the downloads page shows the refreshed date and that the marking message carries no SQL.

LLM disclosure

LLM was used to find, diagnose explain and fix this issue. With human review.

Comments

gábor hojtsy created an issue. See original summary.

  • 58980d90 committed on 7.x-1.x
    fix #3621651: Packager tools: "Repackage now" skips releases never...

  • 76c152a8 committed on 3.0.x
    fix #3621651: Packager tools: "Repackage now" skips releases never...
gábor hojtsy’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.