Fix code style issues

I took a look at it @anybody, and the phpcs errors, and cspell suggestions I could fix.

It said that a component in photoswipe/modules/photoswipe_dynamic_caption/photoswipe_dynamic_caption.module was no longer used:

----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Type Drupal\Component\Utility\Xss is not used in this file.
----------------------------------------------------------------------------------------------------------------------

... and it does seem use of Xss::filter was removed here:

-          // The caption value needs to get escaped:
-          $caption = Xss::filter($fieldValue);
+          // Assign the field value to the caption:
+          $caption = $fieldValue;

From "Improve caption value output"
https://git.drupalcode.org/project/photoswipe/-/commit/b70e9a47ca1174644...

But probably best to double check this change in the MR.

There are also some more complicated tasks, like warnings about converting \Drupal::service to a dependency injection, which is a bit beyond my basic coding skills:

$ ddev exec ./vendor/bin/phpcs --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml --standard=Drupal,DrupalPractice web/modules/contrib/photoswipe -v
[...]
Processing photoswipe.theme.inc [209 tokens in 43 lines]... DONE in 4ms (0 errors, 0 warnings)
FILE: /var/www/html/web/modules/contrib/photoswipe/src/Form/PhotoswipeSettings.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 433 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
[...]

It seems like the phpcs and cspell tests are now green, but like you wrote, perhaps some more work is needed here?

Not really a novice task, as the failures need some major refactoring.

All green now!

Thanks ressa for your initial work! I created a seperate branch, since this needed some further work, and some changes weren't necessarily needed (e.g. README adjustments and the @codingStyleIgnoreX removals).

Please review @anybody!

Thank you @grevil! Nice to see all tests are now green :)

Sorry about the change in the "Assigned" field, I am not sure why that happened?

I only changed the Status to "Needs review", but maybe that affected that field as well? (and I cannot add @anybody)