Problem/Motivation

There are several constructor arguments that have backward compatibility code that needs removing in 12.0.0:

@trigger_error('Calling ' . __METHOD__ . '() without the $some_service argument is deprecated in drupal:11.x.0 and the $some_service argument will be required in drupal:12.0.0. See https://www.drupal.org/node/...', E_USER_DEPRECATED);

Steps to reproduce

Proposed resolution

Remove the BC layer.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3620747-nr-bot__59d8i7h.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3620747

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Normal » Critical

longwave-bot made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !16977

smustgrave’s picture

smustgrave commented

Small phpcs error

smustgrave’s picture

smustgrave commented

Pushed a small change for tests to run.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Tests all green looks like good removals.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3620747-nr-bot__59d8i7h.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Fixed conflict with #3620912: Deprecate user.module cancel methods

  • godotislate committed bb5d24ea on main 
    task: #3620747 Remove deprecated method arguments tagged for 12.0.0

By...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

I did a search for regexp without the.*drupal:12.0.0 and found these recent additions:

  • core/modules/jsonapi/src/Controller/EntityResource.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $accountCancellation argument is deprecated in drupal:11.5.0 and it will be required ...
  • core/modules/update/src/UpdateManager.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $updateCalculator argument is deprecated in drupal:11.5.0 and it will be required in ...
  • core/modules/user/src/AccountSettingsForm.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $accountCancellation argument is deprecated in drupal:11.5.0 and it will be required ...
  • core/modules/user/src/EventSubscriber/MaintenanceModeSubscriber.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $logoutFinalizer argument is deprecated in drupal:11.5.0 and is removed from drupal:1...
  • core/modules/user/src/Form/UserMultipleCancelConfirm.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $accountCancellation argument is deprecated in drupal:11.5.0 and it will be required ...
  • core/modules/views/src/Plugin/Block/ViewsBlockBase.php: ...rigger_error('Calling ' . __METHOD__ . '() without the $contextual_links argument is deprecated in drupal:11.4.0 and will be required in dru...

I think these and any others that trickle in the next few days can go in a follow up.
I also had a couple small MR comments, but they're follow up material as well:
$this->updateType = $updateType; in UpdateRegistry::__construct() can probably be removed
property promotion in core/modules/ckeditor5/src/Plugin/CKEditor5Plugin/Image.php can be handled in #3278431: [May 2026] Use PHP 8 constructor property promotion for existing code

Committed bb5d24e and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smustgrave’s picture

smustgrave commented

I have a ticket to clean up any remainders trying to see what’s left after these few land