Problem/Motivation

The Htmx factory class for HTMX 4 is missing two new attributes:

hx-morph-skip - freezes an element during a morph swap
hx-morph-skip-children - morphs an element’s attributes but keeps its children

Proposed resolution

Add supporting methods to Htmx

Remaining tasks

Add the methods

User interface changes

none

Introduced terminology

none

API changes

New methods on Htmx class

Data model changes

none

Release notes snippet

none but update the htmx 4 CR once complete

Issue fork drupal-3620407

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fathershawn created an issue. See original summary.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Title: Add missing HTMX 4 morph attributes » PP-1 Add missing HTMX 4 morph attributes
Status: Active » Postponed
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Title: PP-1 Add missing HTMX 4 morph attributes » Add missing HTMX 4 morph attributes
Status: Postponed » Active

fathershawn opened merge request !17011

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Active » Needs review
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Unrelated test failing: core/modules/field/tests/src/Functional/Update/RecalculateDependenciesUpdateTest.php

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Issue tags: +12.0.0 release priority
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reviewing this based on what's already there. Seems to be adding 2 new ones which seems fine.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thanks @smustgrave! Yes, @cosmicdreams caught the late additions to their API and as we were already RTBC we decided to handle this in a follow-up.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

I will update the published CR for the parent issue when this is committed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs change record updates

Committed and pushed 448cc516b3a to main. Thanks!

This is in, thanks - tagging for CR updates

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • larowlan committed 448cc516 on main 
    task: #3620407 Add missing HTMX 4 morph attributes

By: fathershawn

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.