[2.x] Vidyard

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

1. FILE: README.md

The README file is missing the required sections - Requirements, Installation and Configuration.

2. FILE: vidyard.module

For a module that aims to be compatible with Drupal 10 and Drupal 11, I would rather implement hooks as class methods as described in Support for object oriented hook implementations using autowired services.

3. FILE: src/Plugin/media/Source/Vidyard.php

Projects that are compatible with Drupal 10 or higher versions should use attributes instead of annotations.

Reviewed 2.x at a2be701.

src/VidyardUuid.php

  public const PATTERN = '/(?:https?:)?\/\/(?:[a-zA-Z0-9-]+\.)+vidyard\.com\/(?:share\/|watch\/)?(?<id>[a-zA-Z0-9_-]+)/i';

Any first path segment on any vidyard.com host is taken as a player UUID: https://www.vidyard.com/pricing yields pricing, and mediaViewAlter() then renders an img pointing at https://play.vidyard.com/pricing.jpg. Restrict the hosts to the player ones (play, share, embed, *.hubs) or the id to the UUID shape Vidyard uses.

src/Hook/VidyardHooks.php

      foreach ($replacements as $delta => $element) {
        $build[$name][$delta] = $element;
      }
      break;
    }

The loop over the display components stops after the first field that has the setting, so a media type with two oEmbed fields using the v4 player gets it on one of them only.

  public function __construct(
    protected EntityTypeManagerInterface $entity_type_manager,
  ) {}

Class properties use lowerCamelCase ($entityTypeManager); a promoted parameter is a property.

composer.json

  "require": {
    "drupal/core": "^10.4 || ^11"
  }

drupal.org packaging derives the core constraint from core_version_requirement in the info file; declaring drupal/core in the project's composer.json is not necessary and the two can disagree. With no other dependency, the composer.json can be removed.

phpstan.neon

parameters:
  level: 0

The GitLab template uses the project's phpstan.neon when it exists, so this file lowers the pipeline to level 0 and hides what the default level would report. Either remove it or raise the level.

.dev/composer.json, .dev/phpunit.xml.dist, .lando.yml

Local development tooling that ends up in the packaged release. If it has to stay in the repository, mark it export-ignore in .gitattributes so the tarball does not ship it.

README.md

"This GitHub repository is a mirror of git.drupalcode.org/project/vidyard" is text written for GitHub; on drupal.org it reads as if the project lived elsewhere. The Local development section belongs in a CONTRIBUTING file rather than in the README that ends up on the project page.

AI-Generated: Yes (AI tools helped with this review; I checked each point myself.)

so this file lowers the pipeline to level 0 and hides what the default level would report.

The default level for gitlab_templates is 0.
https://git.drupalcode.org/project/gitlab_templates/-/blob/cc3ce7dae32e0...

Keeping the tested level in the project is industry common practice.